ACI #88
Open
ACI #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sk593
reviewed
Mar 26, 2025
sk593
reviewed
Mar 26, 2025
sk593
reviewed
Mar 26, 2025
sk593
reviewed
Mar 26, 2025
sk593
reviewed
Mar 26, 2025
sk593
reviewed
Mar 26, 2025
sk593
reviewed
Mar 26, 2025
ytimocin
reviewed
Mar 26, 2025
sk593
reviewed
Mar 26, 2025
ytimocin
reviewed
Mar 26, 2025
kachawla
reviewed
Mar 26, 2025
willtsai
reviewed
Mar 26, 2025
sk593
reviewed
Mar 26, 2025
lakshmimsft
reviewed
Mar 26, 2025
ytimocin
reviewed
Mar 26, 2025
kachawla
reviewed
Mar 26, 2025
kachawla
reviewed
Mar 26, 2025
sk593
reviewed
Mar 26, 2025
Signed-off-by: Brooke Hamilton <45323234+brooke-hamilton@users.noreply.github.com>
Signed-off-by: Brooke Hamilton <45323234+brooke-hamilton@users.noreply.github.com>
Signed-off-by: Brooke Hamilton <45323234+brooke-hamilton@users.noreply.github.com>
Signed-off-by: Brooke Hamilton <45323234+brooke-hamilton@users.noreply.github.com>
Signed-off-by: Brooke Hamilton <45323234+brooke-hamilton@users.noreply.github.com>
Signed-off-by: Brooke Hamilton <45323234+brooke-hamilton@users.noreply.github.com>
Signed-off-by: Brooke Hamilton <45323234+brooke-hamilton@users.noreply.github.com>
Signed-off-by: Brooke Hamilton <45323234+brooke-hamilton@users.noreply.github.com>
Signed-off-by: Brooke Hamilton <45323234+brooke-hamilton@users.noreply.github.com>
Signed-off-by: Brooke Hamilton <45323234+brooke-hamilton@users.noreply.github.com>
Signed-off-by: Brooke Hamilton <45323234+brooke-hamilton@users.noreply.github.com>
sk593
reviewed
May 21, 2025
| name: 'aci-env' | ||
| properties: { | ||
| compute: { | ||
| - kind: 'kubernetes' |
There was a problem hiding this comment.
We ended up sticking with the original implementation of kind + resource group with the expectation that it'd get replaced with extensibility
sk593
reviewed
May 21, 2025
| + replicas: 5 | ||
| + } | ||
| extensions: [ | ||
| - { |
There was a problem hiding this comment.
Same as above. We kept the POC implementation
sk593
reviewed
May 21, 2025
| hostNetwork: true | ||
| } | ||
| } | ||
| + aci: { // Container group profile properties |
There was a problem hiding this comment.
The only property we added here was gatewayID (again with the expectation that compute extensibility would replace it)
sk593
approved these changes
May 21, 2025
Signed-off-by: Brooke Hamilton <45323234+brooke-hamilton@users.noreply.github.com>
Signed-off-by: Brooke Hamilton <45323234+brooke-hamilton@users.noreply.github.com>
brooke-hamilton
added a commit
that referenced
this pull request
Jun 27, 2025
This document was originally part of #88. It is now in its own PR. --------- Signed-off-by: Brooke Hamilton <45323234+brooke-hamilton@users.noreply.github.com>
sylvainsf
previously approved these changes
Jun 27, 2025
looking forward to deprecating this soon! :)Signed-off-by: Brooke Hamilton <45323234+brooke-hamilton@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: there is a separate extensibility design at PR #91. This document covers adding ACI support.