Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Substitute symbol addrs more correctly #680

Open
montekki opened this issue Mar 3, 2014 · 10 comments
Open

Substitute symbol addrs more correctly #680

montekki opened this issue Mar 3, 2014 · 10 comments

Comments

@montekki
Copy link
Contributor

montekki commented Mar 3, 2014

if a hexadecimal address has a suffix (say, "0xbeef:16") it won't be substituted with symbol name:

radare1
radare2

@XVilka XVilka added the bug label Mar 3, 2014
@XVilka XVilka added this to the 0.9.8 milestone Mar 3, 2014
@radare
Copy link
Collaborator

radare commented Mar 6, 2014

How to differentiate to segmented x86 addressing?

@montekki
Copy link
Contributor Author

look at the binary's arch?

@radare
Copy link
Collaborator

radare commented Mar 11, 2014

i would prefer to be arch-independent, if a human can understand the disasm, a parser should too..

On 11 Mar 2014, at 08:27, Fedor Sakharov notifications@github.com wrote:

look at the binary's arch?


Reply to this email directly or view it on GitHub.

@radare radare modified the milestones: 0.9.9, 0.9.8 Jul 1, 2014
@radare radare modified the milestones: 1.0.0, 0.9.9 Dec 1, 2014
@XVilka XVilka added the RAnal label May 12, 2016
@XVilka XVilka modified the milestones: 0.10.5, 1.0.0 May 12, 2016
@radare radare modified the milestones: 0.10.6, 0.10.5 Aug 8, 2016
@radare
Copy link
Collaborator

radare commented Sep 21, 2016

ping @montekki can you send a pr for that? checking for arch can be a dirty but working solution, so having this done with a couple of tests would be good for me

@radare
Copy link
Collaborator

radare commented Sep 21, 2016

also we can differentiate if the number starts with # instead of just 0x and if it contains :

@radare radare modified the milestones: 1.x, 0.10.6 Sep 21, 2016
@radare radare modified the milestones: 1.1.0, 1.0.0 Nov 4, 2016
@radare radare modified the milestones: 1.2.0, 1.1.0 Nov 24, 2016
@radare
Copy link
Collaborator

radare commented Nov 24, 2016

anyone?

@radare radare modified the milestones: 1.3.0, 1.2.0 Jan 13, 2017
@Maijin
Copy link
Contributor

Maijin commented Feb 19, 2017

Can we have test-case or something to reproduce this 0xXXX:16 syntax ?

@radare
Copy link
Collaborator

radare commented Feb 20, 2017 via email

@Maijin
Copy link
Contributor

Maijin commented Feb 20, 2017

Whoever got something to reproduce

@radare radare added this to the 1.5.0 milestone Mar 10, 2017
@radare radare removed this from the 1.3.0 milestone Mar 10, 2017
@radare radare modified the milestones: 1.6.0, 1.5.0 May 28, 2017
@radare radare modified the milestones: 9999, 1.6.0 Jul 9, 2017
@trufae
Copy link
Collaborator

trufae commented Jun 11, 2020

Without a test case this issue is quite difficult to handle/understand/fix.

@trufae trufae removed the bug label Jun 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants