Define number of lines when output is large

[radare]

When output is too big in scr.interactive there should be more options than just "Yes" or "No".

I'm proposing the following:

• p : use scr.pager (less, more, ..)
• 10 : any numeric argument will assume that it must flush only the first 10 lines and drop the rest.

We can add r_cons_head() and r_cons_tail() functions to chop the non-flushed buffer.

[jvoisin]

What about pager instead of p, since it's not that obvious.

[radare]

The yesno() expects only 1 char

On 17 Jan 2015, at 05:05, jvoisin notifications@github.com wrote:

What about pager instead of p, since it's not that obvious.

—
Reply to this email directly or view it on GitHub.

[radare]

the value in scr.interactive can be pager perfectly. i was talking about the function itself

[radare]

instead of saying "wanna dump 300KB of text" just say: "wanna see 200 lines of text?"

[stale]

This issue has been automatically marked as stale because it has not had recent activity. Considering a lot has changed since its creation, we kindly ask you to check again if the issue you reported is still relevant in the current version of radare2. If it is, update this issue with a comment, otherwise it will be automatically closed if no further activity occurs. Thank you for your contributions.

[trufae]

Still waiting for feedback or comments after 5 years. Personally i dont think we need any configuration overcomplications here. but maybe its worth to check when the output contains a very long line show in size instead of lines. to confirm the user, because a 100MB single line will just say: "do you want to print 1 line?" which makes not much sense to warn the user for that when the reality is another.

So yeah, this bug must be fixed still

[alex-bender]

@trufae I'm going to check that

[alex-bender]

Any hints where to start?

[trufae]

i would start like this:

[0x100001060]> cat /etc/services
Do you want to print 13921 lines? (y/N)

grep in the r2 source code to find this message. ( git grep 'Do you want to print')

when found. youll see something like this:

so the steps to solve this problem would be:

• Remove the COUNT_LINES ifdef, the else branch have not been used and its not that slow to count chars everytime we print something..
• Move the count lines to a separate function
• Make this function count an extra line every time there's a line with more than 80 chars