Add to the word-break property support of the break-word value (CSS3)

Adam Gabryś · racodond · commit d5f6b5968d75 · 2018-05-22T11:40:49.000+02:00
diff --git a/css-checks/src/test/resources/checks/common/properties/css/word-break.css b/css-checks/src/test/resources/checks/common/properties/css/word-break.css
@@ -3,6 +3,7 @@
   word-break: normal;
   word-break: keep-all;
   word-break: break-all;
-  word-break: abc; /* Noncompliant !{Update the invalid value of property "word-break". Expected format: normal | keep-all | break-all}! */
+  word-break: break-word;
+  word-break: abc; /* Noncompliant !{Update the invalid value of property "word-break". Expected format: normal | keep-all | break-all | break-word}! */
   word-break: 10; /* Noncompliant */
 }
diff --git a/css-checks/src/test/resources/checks/common/properties/less/word-break.less b/css-checks/src/test/resources/checks/common/properties/less/word-break.less
@@ -3,6 +3,7 @@
   word-break: normal;
   word-break: keep-all;
   word-break: break-all;
-  word-break: abc; /* Noncompliant !{Update the invalid value of property "word-break". Expected format: normal | keep-all | break-all}! */
+  word-break: break-word;
+  word-break: abc; /* Noncompliant !{Update the invalid value of property "word-break". Expected format: normal | keep-all | break-all | break-word}! */
   word-break: 10; /* Noncompliant */
 }
diff --git a/css-checks/src/test/resources/checks/common/properties/scss/word-break.scss b/css-checks/src/test/resources/checks/common/properties/scss/word-break.scss
@@ -3,6 +3,7 @@
   word-break: normal;
   word-break: keep-all;
   word-break: break-all;
-  word-break: abc; /* Noncompliant !{Update the invalid value of property "word-break". Expected format: normal | keep-all | break-all}! */
+  word-break: break-word;
+  word-break: abc; /* Noncompliant !{Update the invalid value of property "word-break". Expected format: normal | keep-all | break-all | break-word}! */
   word-break: 10; /* Noncompliant */
 }
diff --git a/css-frontend/src/main/java/org/sonar/css/model/property/standard/WordBreak.java b/css-frontend/src/main/java/org/sonar/css/model/property/standard/WordBreak.java
@@ -25,8 +25,8 @@
 public class WordBreak extends StandardProperty {
 
   public WordBreak() {
-    addLinks("https://drafts.csswg.org/css-text-3/#propdef-word-break");
-    addValidators(new IdentifierValidator("normal", "keep-all", "break-all"));
+    addLinks("https://www.w3.org/TR/css-text-3/#word-break-property");
+    addValidators(new IdentifierValidator("normal", "keep-all", "break-all", "break-word"));
   }
 
 }
diff --git a/its/ruling/projects/custom/common/properties/css/word-break.css b/its/ruling/projects/custom/common/properties/css/word-break.css
@@ -3,6 +3,7 @@
   word-break: normal;
   word-break: keep-all;
   word-break: break-all;
-  word-break: abc; /* Noncompliant !{Update the invalid value of property "word-break". Expected format: normal | keep-all | break-all}! */
+  word-break: break-word;
+  word-break: abc; /* Noncompliant !{Update the invalid value of property "word-break". Expected format: normal | keep-all | break-all | break-word}! */
   word-break: 10; /* Noncompliant */
 }
diff --git a/its/ruling/projects/custom/common/properties/less/word-break.less b/its/ruling/projects/custom/common/properties/less/word-break.less
@@ -3,6 +3,7 @@
   word-break: normal;
   word-break: keep-all;
   word-break: break-all;
-  word-break: abc; /* Noncompliant !{Update the invalid value of property "word-break". Expected format: normal | keep-all | break-all}! */
+  word-break: break-word;
+  word-break: abc; /* Noncompliant !{Update the invalid value of property "word-break". Expected format: normal | keep-all | break-all | break-word}! */
   word-break: 10; /* Noncompliant */
 }
diff --git a/its/ruling/projects/custom/common/properties/scss/word-break.scss b/its/ruling/projects/custom/common/properties/scss/word-break.scss
@@ -3,6 +3,7 @@
   word-break: normal;
   word-break: keep-all;
   word-break: break-all;
-  word-break: abc; /* Noncompliant !{Update the invalid value of property "word-break". Expected format: normal | keep-all | break-all}! */
+  word-break: break-word;
+  word-break: abc; /* Noncompliant !{Update the invalid value of property "word-break". Expected format: normal | keep-all | break-all | break-word}! */
   word-break: 10; /* Noncompliant */
 }
diff --git a/its/ruling/tests/src/test/expected/css-line-length.json b/its/ruling/tests/src/test/expected/css-line-length.json
@@ -1091,7 +1091,7 @@
 9,
 ],
 'project:custom/common/properties/css/word-break.css':[
-6,
+7,
 ],
 'project:custom/common/properties/css/word-spacing.css':[
 8,
diff --git a/its/ruling/tests/src/test/expected/css-validate-property-value.json b/its/ruling/tests/src/test/expected/css-validate-property-value.json
@@ -1659,8 +1659,8 @@
 10,
 ],
 'project:custom/common/properties/css/word-break.css':[
-6,
 7,
+8,
 ],
 'project:custom/common/properties/css/word-spacing.css':[
 8,
diff --git a/its/ruling/tests/src/test/expected/less-line-length.json b/its/ruling/tests/src/test/expected/less-line-length.json
@@ -991,7 +991,7 @@
 9,
 ],
 'project:custom/common/properties/less/word-break.less':[
-6,
+7,
 ],
 'project:custom/common/properties/less/word-spacing.less':[
 8,
diff --git a/its/ruling/tests/src/test/expected/less-prefer-single-line-comments.json b/its/ruling/tests/src/test/expected/less-prefer-single-line-comments.json
@@ -1917,8 +1917,8 @@
 10,
 ],
 'project:custom/common/properties/less/word-break.less':[
-6,
 7,
+8,
 ],
 'project:custom/common/properties/less/word-spacing.less':[
 8,
diff --git a/its/ruling/tests/src/test/expected/less-validate-property-value.json b/its/ruling/tests/src/test/expected/less-validate-property-value.json
@@ -1652,8 +1652,8 @@
 10,
 ],
 'project:custom/common/properties/less/word-break.less':[
-6,
 7,
+8,
 ],
 'project:custom/common/properties/less/word-spacing.less':[
 8,
diff --git a/its/ruling/tests/src/test/expected/scss-line-length.json b/its/ruling/tests/src/test/expected/scss-line-length.json
@@ -1009,7 +1009,7 @@
 9,
 ],
 'project:custom/common/properties/scss/word-break.scss':[
-6,
+7,
 ],
 'project:custom/common/properties/scss/word-spacing.scss':[
 8,
diff --git a/its/ruling/tests/src/test/expected/scss-prefer-single-line-comments.json b/its/ruling/tests/src/test/expected/scss-prefer-single-line-comments.json
@@ -1934,8 +1934,8 @@
 10,
 ],
 'project:custom/common/properties/scss/word-break.scss':[
-6,
 7,
+8,
 ],
 'project:custom/common/properties/scss/word-spacing.scss':[
 8,
diff --git a/its/ruling/tests/src/test/expected/scss-validate-property-value.json b/its/ruling/tests/src/test/expected/scss-validate-property-value.json
@@ -1611,8 +1611,8 @@
 10,
 ],
 'project:custom/common/properties/scss/word-break.scss':[
-6,
 7,
+8,
 ],
 'project:custom/common/properties/scss/word-spacing.scss':[
 8,

Original file line number	Diff line number	Diff line change
`@@ -3,6 +3,7 @@`
`3`	`3`	`word-break: normal;`
`4`	`4`	`word-break: keep-all;`
`5`	`5`	`word-break: break-all;`
`6`		`- word-break: abc; /* Noncompliant !{Update the invalid value of property "word-break". Expected format: normal \| keep-all \| break-all}! */`
	`6`	`+ word-break: break-word;`
	`7`	`+ word-break: abc; /* Noncompliant !{Update the invalid value of property "word-break". Expected format: normal \| keep-all \| break-all \| break-word}! */`
`7`	`8`	`word-break: 10; /* Noncompliant */`
`8`	`9`	`}`
Original file line number	Diff line number	Diff line change
`@@ -25,8 +25,8 @@`
`25`	`25`	`public class WordBreak extends StandardProperty {`
`26`	`26`
`27`	`27`	`public WordBreak() {`
`28`		`- addLinks("https://drafts.csswg.org/css-text-3/#propdef-word-break");`
`29`		`- addValidators(new IdentifierValidator("normal", "keep-all", "break-all"));`
	`28`	`+ addLinks("https://www.w3.org/TR/css-text-3/#word-break-property");`
	`29`	`+ addValidators(new IdentifierValidator("normal", "keep-all", "break-all", "break-word"));`
`30`	`30`	`}`
`31`	`31`
`32`	`32`	`}`