Skip to content

CIDM-1283 Add SSL Tuning options to container config #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 22, 2018
Merged

CIDM-1283 Add SSL Tuning options to container config #83

merged 1 commit into from
May 22, 2018

Conversation

scarlettmoonbell
Copy link
Contributor

  • Add Include/Exclude protocol and TLS renegotiation options to container filter

dimtruck
dimtruck suggested changes May 21, 2018
View reviewed changes
templates/container.cfg.xml.erb Outdated
</included-protocols>
<%- end -%>
<%- unless @ssl_tls_renegotiation.nil? -%>
<tls-renegotiation-allowed><%= ssl_tls_renegotiation -%></tls-renegotiation-allowed>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be @ssl_tls_renegotiation

@scarlettmoonbell scarlettmoonbell force-pushed the CIDM-1283-add-ssl-tuning-options branch from c16f02f to fe30baf Compare May 21, 2018 17:36
@gregswift
Copy link
Contributor

gregswift commented May 21, 2018 •
edited
Loading

some example syntax? what are valid values? if upstream repose docs, a link would suffice

@scarlettmoonbell scarlettmoonbell force-pushed the CIDM-1283-add-ssl-tuning-options branch from fe30baf to e58d189 Compare May 21, 2018 19:08
@scarlettmoonbell
Copy link
Contributor Author

scarlettmoonbell commented May 21, 2018 •
edited
Loading

@gregswift - Added link to container config repose page at top of container filter manifest due to preexisting options can benefit.

rackergs
rackergs approved these changes May 21, 2018
View reviewed changes
Copy link
Contributor

@rackergs rackergs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i love when people know how to do ERB on XML 😀

@jstraw jstraw merged commit f11a75f into rackerlabs:master May 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jstraw jstraw jstraw approved these changes

@dimtruck dimtruck dimtruck approved these changes

@rackergs rackergs rackergs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@scarlettmoonbell @gregswift @jstraw @dimtruck @rackergs