Merge pull request #86 from lokeshbelwaltx/master

log_file_perm param added to modify log file permission as world read

Author: jstraw

ModuleFile

@@ -1,5 +1,5 @@
 name 'citops-repose'
-version '2.7.0'
+version '2.10.0'
 description "Repose is an api middleware that provides authentication,
 filtering, ratelimitting and several other features, this deploys it."
 project_page 'https://github.com/rackerlabs/puppet-repose'

manifests/filter/container.pp

@@ -101,6 +101,13 @@
 # server.
 # Defaults to <tt>local0</tt>
 #
+# [*log_file_perm*]
+# String. This option can be used to provide world read access on repose logs.
+# if value='private' OR [not equals 'public'] will follow the os umap 
+# permission of repose user.
+# if value='public' will provide world read access on log files.
+# Defaults to <tt>private</tt>
+#
 # [*log_use_log4j2*]
 # Boolean. This option will enable the use of log4j2 xml configuration files.
 # This will override <tt>logging_configuration</tt> to use <tt>log4j2.xml</tt>.
@@ -308,6 +315,7 @@
   $log_local_size                       = $repose::params::log_local_size,
   $log_local_rotation_count             = $repose::params::log_local_rotation_count,
   $log_repose_facility                  = $repose::params::log_repose_facility,
+  $log_file_perm                        = $repose::params::log_file_perm,
   $log_use_log4j2                       = false,
   $logging_configuration                = $repose::params::logging_configuration,
   $ssl_enabled                          = false,

manifests/params.pp

@@ -243,4 +243,7 @@
 
 ## use new namespace urls in configuration files
   $cfg_new_namespace = false
+  
+## default log file permissions
+  $log_file_perm = 'private'
 }

puppet-module-repose.spec

@@ -2,7 +2,7 @@
 %define base_name repose
 
 Name:      puppet-module-%{user}-%{base_name}
-Version:   2.9.0
+Version:   2.10.0
 Release:   1
 BuildArch: noarch
 Summary:   Puppet module to configure %{base_name}
@@ -30,6 +30,8 @@ cp -pr * %{buildroot}%{module_dir}/
 %{module_dir}
 
 %changelog
+* Tue Jun 18 2019 Lokesh Belwal <Lokesh.Belwal@rackspace.com> - 2.10.0-1
+- Add log_file_perm param to provide world read access on logs if set to 'public' 
 * Mon Dec 17 2018 Josh Bell <josh.bell@rackspace.com> - 2.9.0-1
 - Add via_header and repose_version options to container filter
 * Mon May 12 2018  Josh Bell <josh.bell@rackspace.com> - 2.8.0-1

templates/log4j2.xml.erb

@@ -26,7 +26,11 @@
 <%- elsif @log_local_policy == 'size' -%>
         <RollingFile name="defaultFile"
             filename="<%= @log_dir-%>/<%= @app_name -%>.log"
-            filePattern="<%= @log_dir-%>/<%= @app_name -%>.log.%i">
+            filePattern="<%= @log_dir-%>/<%= @app_name -%>.log.%i" 
+            <%- if @log_file_perm == 'public' -%>
+              filePermissions="rw-r--r--"
+            <%- end -%>
+              >
             <PatternLayout>
                 <Pattern>%d{yyyy-MM-dd HH:mm:ss} %-4r [%t] %-5p %c %x - %m%n</Pattern>
             </PatternLayout>
@@ -93,7 +97,11 @@
   <%- elsif @log_local_policy == 'size' -%>
         <RollingFile name="httpLocal"
             filename="<%= @log_dir-%>/<%= @log_access_local_name -%>.log"
-            filePattern="<%= @log_dir-%>/<%= @log_access_local_name -%>.log.%i">
+            filePattern="<%= @log_dir-%>/<%= @log_access_local_name -%>.log.%i"
+            <%- if @log_file_perm == 'public' -%>
+              filePermissions="rw-r--r--"
+            <%- end -%>
+              >
             <PatternLayout>
                 <Pattern>%m%n</Pattern>
             </PatternLayout>