This repository was archived by the owner on Aug 28, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6
Update Service Account descriptions #13
Merged
ltvolks
merged 3 commits into
rackerlabs:master
from
ltvolks:ltvolks/add-service-accounts
Jan 19, 2021
Merged
Update Service Account descriptions #13
ltvolks
merged 3 commits into
rackerlabs:master
from
ltvolks:ltvolks/add-service-accounts
Jan 19, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ltvolks
commented
Jan 15, 2021
- Updates service account descriptions w/ current roles required
- Fixes build warning:
catlook
suggested changes
Jan 18, 2021
Contributor
catlook
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some suggested edits
ltvolks
commented
Jan 18, 2021
Collaborator
Author
ltvolks
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inline suggestions updated
catlook
approved these changes
Jan 18, 2021
Contributor
catlook
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
upodroid
approved these changes
Jan 19, 2021
upodroid
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I read the entire docs btw there are several things in there that need updating:
- https://developer.rackspace.com/docs/fanatical-support-gcp/support/#phone
The numbers are out of date and the link is broken. - https://developer.rackspace.com/docs/fanatical-support-gcp/security/#security-updates
This security advisory is from 3 years ago and has been patched a long time ago. - https://developer.rackspace.com/docs/fanatical-support-gcp/billing/
Billing file exports are deprecated and shouldn't be recommended anymore - https://developer.rackspace.com/docs/fanatical-support-gcp/billing/#native-gcp-project-billing-account-access
Mention the Google role Billing Account Administrator instead of billing:admin - https://developer.rackspace.com/docs/fanatical-support-gcp/gcp-projects/offboarding/
Do we want to make the customer steps of the unboarding public? - https://developer.rackspace.com/docs/fanatical-support-gcp/support/#runway-service-level
This needs to be removed or clarified.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.