Skip to content
This repository was archived by the owner on Aug 28, 2024. It is now read-only.

Conversation

@ltvolks
Copy link
Collaborator

@ltvolks ltvolks commented Jan 15, 2021

  • Updates service account descriptions w/ current roles required
  • Fixes build warning:
- docs-gcp/docs/service-blocks/index.rst:19: WARNING: Title underline too short.

Platform Essentials
^^^^^^^^^^^^^^^^

Copy link
Contributor

@catlook catlook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some suggested edits

Copy link
Collaborator Author

@ltvolks ltvolks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inline suggestions updated

Copy link
Contributor

@catlook catlook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link

@upodroid upodroid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I read the entire docs btw there are several things in there that need updating:

@ltvolks ltvolks merged commit da2387f into rackerlabs:master Jan 19, 2021
@ltvolks ltvolks deleted the ltvolks/add-service-accounts branch January 19, 2021 19:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants