Skip to content

Set inflight queue size to the initial credits #409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Gsantomaggio merged 4 commits into from
Jun 30, 2025
Merged

Set inflight queue size to the initial credits #409

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c9bb473
chore: re-add check in test command Makefile
hiimjako Jun 26, 2025
e98a297
feat: set the consumer chunk channel size equal to the initial credits
hiimjako Jun 26, 2025
c65504c
chore: run lint inside build_and_test
hiimjako Jun 30, 2025
e84f59a
fix: tests
hiimjako Jun 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ check:

NUM_PROCS ?= 2
TEST_TIMEOUT ?= 3m
test: vet fmt
test: vet fmt check
go run -mod=mod github.com/onsi/ginkgo/v2/ginkgo -r --procs=$(NUM_PROCS) --compilers=$(NUM_PROCS) \
--randomize-all --randomize-suites \
--cover --coverprofile=coverage.txt --covermode=atomic \
Expand Down
2 changes: 1 addition & 1 deletion pkg/stream/coordinator.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ func (coordinator *Coordinator) NewConsumer(messagesHandler MessagesHandler,
lastStoredOffset: -1, // because 0 is a valid value for the offset
isPromotedAsActive: true,
lastAutoCommitStored: time.Now(),
chunkForConsumer: make(chan chunkInfo, 100),
chunkForConsumer: make(chan chunkInfo, parameters.initialCredits),
onClose: cleanUp,
}

Expand Down
Loading