Skip to content

Conversation

@Gsantomaggio
Copy link
Member

@Gsantomaggio Gsantomaggio commented May 22, 2021

rabbitmq/rabbitmq-server#3060
fix offest client side and test

@codecov-commenter
Copy link

codecov-commenter commented May 22, 2021

Codecov Report

Merging #40 (bd32e27) into main (2e27e46) will decrease coverage by 0.95%.
The diff coverage is 62.96%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #40      +/-   ##
==========================================
- Coverage   78.70%   77.75%   -0.96%     
==========================================
  Files          14       15       +1     
  Lines        1207     1263      +56     
==========================================
+ Hits          950      982      +32     
- Misses        188      212      +24     
  Partials       69       69              
Impacted Files Coverage Δ
pkg/stream/enviroment.go 73.49% <0.00%> (-3.08%) ⬇️
pkg/stream/enviroment_debug.go 0.00% <0.00%> (ø)
pkg/stream/socket.go 78.57% <ø> (ø)
pkg/stream/constants.go 72.34% <50.00%> (ø)
pkg/stream/consumer.go 79.20% <53.84%> (+0.26%) ⬆️
pkg/stream/server_frame.go 69.95% <76.92%> (+2.78%) ⬆️
pkg/stream/client.go 81.09% <85.71%> (+0.46%) ⬆️
pkg/stream/coordinator.go 93.51% <100.00%> (ø)
pkg/stream/producer.go 70.90% <100.00%> (ø)
pkg/stream/utils.go 81.81% <100.00%> (+11.22%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e27e46...bd32e27. Read the comment docs.

@Gsantomaggio Gsantomaggio changed the title Send Send advertised host and port in open Send advertised host and port in open May 22, 2021
remove pre-declared option on the perf test, in the same way as Java client does. It checks the PreconditionFailed
condition. cc @gerhard
@Gsantomaggio Gsantomaggio merged commit dd2f9a0 into main May 23, 2021
@Gsantomaggio Gsantomaggio deleted the advertised_host_open branch May 23, 2021 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants