Reuse the locator connection #388
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
add condition for the restart Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
Gsantomaggio
changed the title
hiimjako
previously approved these changes
Apr 8, 2025
Co-authored-by: Alberto Moretti <58828402+hiimjako@users.noreply.github.com>
Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
hiimjako
added a commit
to hiimjako/rabbitmq-stream-go-client
that referenced
this pull request
Jun 14, 2025
- Reuse the locator connection. In this PR, the locator connection is always open ( like most other clients ) and can be reused. It is useful when API like `storeOffset` or `queryOffest` are often called. The `maybeReconnectLocator` function reconnects the locator if/when needed ( in case of network problem|) - Remove one heartbeat Ticket. - Fix an edge case during reconnection when the [metadata fails](https://github.com/rabbitmq/rabbitmq-stream-go-client/pull/388/files#diff-329120e7df50ce65620d4fdf4ce9644909588f2369570cd94ff289b77f3aca2fR62-R66) - closes rabbitmq#387 - Fix a race condition for producer and consumer during the internal close. The internal close now has a [cleanUp function](https://github.com/rabbitmq/rabbitmq-stream-go-client/pull/388/files#diff-da66976f2cef8e369ba583aa16d59f1ea62f43c81eb4586e9d18badc4ed3a867L370-R373) --------- Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com> Co-authored-by: Alberto Moretti <58828402+hiimjako@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
storeOffsetorqueryOffestare often called. ThemaybeReconnectLocatorfunction reconnects the locator if/when needed ( in case of network problem|)