Guard PipeReader.AdvanceTo on closed socket #433
Conversation
Problem: A race during shutdown could call reader.AdvanceTo(buffer.Start, buffer.End) after the TCP socket is closed, risking exceptions that propagate via reader.CompleteAsync(caught) and noisy logs. Change: In Connection.ProcessIncomingFrames, only call reader.AdvanceTo(...) when socket.Connected is true.
|
I’m not sure how to test this, but I see that every time I close a consumer, an InvalidOperationException is thrown from reader.AdvanceTo. |
There was a problem hiding this comment.
Hi @moikot 👋 Thank you for contributing to this client. Recently (a month ago), our company made some changes around open source contribution, and now it's required that you sign a contributor license agreement (CLA) before we can accept your PR.
The process is explained here in this repo README: https://github.com/rabbitmq/cla
Would you review and sign this CLA?
|
the code looks good btw! |
|
@Gsantomaggio Thank you for reviewing the fix and pointing me to the README! I'll start the process immediately! |
|
Thanks @moikot |
|
Thank you, @Gsantomaggio, for the prompt review and for accepting my PR |
Problem: A race during shutdown could call reader.AdvanceTo(buffer.Start, buffer.End) after the TCP socket is closed, risking exceptions that propagate via reader.CompleteAsync(caught) and noisy logs.
Change: In Connection.ProcessIncomingFrames, only call reader.AdvanceTo(...) when socket.Connected is true.