Change the warning messages

Just log the message

Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>

Author: Gsantomaggio

RabbitMQ.Stream.Client/Client.cs

@@ -388,7 +388,7 @@ private async Task HandleIncoming(Memory<byte> frameMemory)
                     break;
                 case CreditResponse.Key:
                     CreditResponse.Read(frame, out var creditResponse);
-                    creditResponse.HandleUnroutableCredit(consumers);
+                    creditResponse.HandleUnRoutableCredit();
                     break;
                 default:
                     HandleCorrelatedCommand(tag, ref frame);

RabbitMQ.Stream.Client/CreditResponse.cs

@@ -4,28 +4,24 @@
 
 using System;
 using System.Buffers;
-using System.Collections.Generic;
-using System.Threading.Tasks;
 
 namespace RabbitMQ.Stream.Client
 {
     public readonly struct CreditResponse : ICommand
     {
         public const ushort Key = 9;
-        private readonly byte subscriptionId;
-        private readonly ResponseCode responseCode;
 
         private CreditResponse(ResponseCode responseCode, byte subscriptionId)
         {
-            this.subscriptionId = subscriptionId;
-            this.responseCode = responseCode;
+            SubscriptionId = subscriptionId;
+            ResponseCode = responseCode;
         }
 
         public int SizeNeeded => throw new NotImplementedException();
 
-        public byte SubscriptionId => subscriptionId;
+        private byte SubscriptionId { get; }
 
-        public ResponseCode ResponseCode => responseCode;
+        private ResponseCode ResponseCode { get; }
 
         public int Write(Span<byte> span)
         {
@@ -43,24 +39,17 @@ internal static int Read(ReadOnlySequence<byte> frame, out CreditResponse comman
             return offset;
         }
 
-        internal void HandleUnroutableCredit(IDictionary<byte, Func<Deliver, Task>> consumers)
+        internal void HandleUnRoutableCredit()
         {
-            /* the server sent a credit-response only in case of 
+            /* the server sends a credit-response only in case of 
              * problem, e.g. crediting an unknown subscription
              * (which can happen when a consumer is closed at 
              * the same time as the deliverhandler is working
              */
 
-            if(consumers.ContainsKey(SubscriptionId) && ResponseCode == ResponseCode.SubscriptionIdDoesNotExist)
-            {
-                LogEventSource.Log.LogWarning($"Consumer subscription has been unregistered " +
-                    $"on the server whlie client was publishing credit command(s)");
-            }
-            else
-            {
-                throw new Exception($"An unexpected {nameof(CreditResponse)} for subscriptionId " +
-                    $"{SubscriptionId} was received with responsecode {ResponseCode}");
-            }
+            LogEventSource.Log.LogWarning(
+                $"Received notification for subscription id: {SubscriptionId} " +
+                $"code: {ResponseCode}");
         }
     }
 }

RabbitMQ.Stream.Client/PublicAPI.Unshipped.txt

@@ -306,9 +306,7 @@ RabbitMQ.Stream.Client.CreditRequest.SizeNeeded.get -> int
 RabbitMQ.Stream.Client.CreditRequest.Write(System.Span<byte> span) -> int
 RabbitMQ.Stream.Client.CreditResponse
 RabbitMQ.Stream.Client.CreditResponse.CreditResponse() -> void
-RabbitMQ.Stream.Client.CreditResponse.ResponseCode.get -> RabbitMQ.Stream.Client.ResponseCode
 RabbitMQ.Stream.Client.CreditResponse.SizeNeeded.get -> int
-RabbitMQ.Stream.Client.CreditResponse.SubscriptionId.get -> byte
 RabbitMQ.Stream.Client.CreditResponse.Write(System.Span<byte> span) -> int
 RabbitMQ.Stream.Client.DeclarePublisherRequest
 RabbitMQ.Stream.Client.DeclarePublisherRequest.DeclarePublisherRequest() -> void