-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
By @Ayanda-D: Ensure only alive leaders and followers when fetching QQ replica states #12727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when checking replica states to help avoid missing inactive replicas e.g. on QQ checks from cli tools (cherry picked from commit 4914850)
and ensure non-existent/inactive/noproc QQ members are not reported. (cherry picked from commit 4e2c62b)
rabbit_quorum_queue:all_replica_states/0 (cherry picked from commit 19cc2d0)
12 tasks
michaelklishin
changed the title
By @Ayanda-D: Ensure only alive leaders and followers when fetching QQ replica states
WIP By @Ayanda-D: Ensure only alive leaders and followers when fetching QQ replica states
Nov 14, 2024
gmake ct-unit_quorum_queue fails repeatably, both on Actions and for locally for me, with
|
test queue processes (since we now check/return only alive members when fetching replica states) (cherry picked from commit ebc0387)
michaelklishin
changed the title
WIP By @Ayanda-D: Ensure only alive leaders and followers when fetching QQ replica states
By @Ayanda-D: Ensure only alive leaders and followers when fetching QQ replica states
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is #12709 by @Ayanda-D with individual commits cherry-picked so that Actions run with my permissions for secrets.