Reduce inefficiency introduced in b636f41 #11297
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use "ERL_LIBS =" instead of "ERL_LIBS :=" so that $(shell ... is not called so often
HoloRin
changed the title
lhoguin
approved these changes
May 22, 2024
Contributor
lhoguin
left a comment
lhoguin
left a comment
There was a problem hiding this comment.
This seems to help but doesn't completely fix the extra time added in the build compared to v3.12.x.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use "ERL_LIBS =" instead of "ERL_LIBS :=" so that $(shell ... is not called so often
as per @lhoguin 's suggestion