Skip to content

Commit fd895aa

Browse files
Return expires_in or exp depending on whats available
1 parent e520ae2 commit fd895aa

File tree

3 files changed

+13
-8
lines changed

3 files changed

+13
-8
lines changed

deps/oauth2_client/src/oauth2_client.erl

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -71,12 +71,17 @@ get_openid_configuration(IssuerURI, OpenIdConfigurationPath, TLSOptions) ->
7171
get_openid_configuration(IssuerURI, TLSOptions) ->
7272
get_openid_configuration(IssuerURI, ?DEFAULT_OPENID_CONFIGURATION_PATH, TLSOptions).
7373

74-
-spec get_expiration_time(successful_access_token_response()) -> {ok, integer()} | {error, missing_exp_field}.
75-
get_expiration_time(#successful_access_token_response{expires_in = ExpiresIn,
74+
-spec get_expiration_time(successful_access_token_response()) ->
75+
{ok, [{expires_in, integer() }| {exp, integer() }]} | {error, missing_exp_field}.
76+
get_expiration_time(#successful_access_token_response{expires_in = ExpiresInSec,
7677
access_token = AccessToken}) ->
77-
case ExpiresIn of
78-
undefined -> jwt_helper:get_expiration_time(jwt_helper:decode(AccessToken));
79-
_ -> {ok, ExpiresIn}
78+
case ExpiresInSec of
79+
undefined ->
80+
case jwt_helper:get_expiration_time(jwt_helper:decode(AccessToken)) of
81+
{ok, Exp} -> {ok, [{exp, Exp}]};
82+
{error, _} = Error -> Error
83+
end;
84+
_ -> {ok, [{expires_in, ExpiresInSec}]}
8085
end.
8186

8287
update_oauth_provider_endpoints_configuration(OAuthProvider) ->

deps/oauth2_client/test/unit_SUITE.erl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ access_token_response_with_expires_in(_) ->
122122
access_token = EncodedToken,
123123
expires_in = ExpiresIn
124124
},
125-
?assertEqual({ok, ExpiresIn}, oauth2_client:get_expiration_time(AccessTokenResponse)).
125+
?assertEqual({ok, [{exoires_in, ExpiresIn}]}, oauth2_client:get_expiration_time(AccessTokenResponse)).
126126

127127
access_token_response_with_exp_in_access_token(_) ->
128128
Jwk = ?UTIL_MOD:fixture_jwk(),
@@ -132,7 +132,7 @@ access_token_response_with_exp_in_access_token(_) ->
132132
AccessTokenResponse = #successful_access_token_response{
133133
access_token = EncodedToken
134134
},
135-
?assertEqual({ok, ExpiresIn}, oauth2_client:get_expiration_time(AccessTokenResponse)).
135+
?assertEqual({ok, [{exp, ExpiresIn}]}, oauth2_client:get_expiration_time(AccessTokenResponse)).
136136

137137
access_token_response_without_expiration_time(_) ->
138138
Jwk = ?UTIL_MOD:fixture_jwk(),

deps/rabbitmq_management/selenium/test/basic-auth/enabled_plugins

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
[accept,amqp10_client,amqp_client,base64url,cowboy,cowlib,eetcd,gun,jose,
2-
oauth2_client,prometheus,rabbitmq_auth_backend_cache,
2+
oauth2_client,prometheus,rabbitmq_amqp1_0,rabbitmq_auth_backend_cache,
33
rabbitmq_auth_backend_http,rabbitmq_auth_backend_ldap,
44
rabbitmq_auth_backend_oauth2,rabbitmq_auth_mechanism_ssl,rabbitmq_aws,
55
rabbitmq_consistent_hash_exchange,rabbitmq_event_exchange,

0 commit comments

Comments
 (0)