From ebc0387b8165af389ba4ecb63c047c5030764014 Mon Sep 17 00:00:00 2001
From: Ayanda Dube <adube14@bloomberg.net>
Date: Fri, 15 Nov 2024 09:22:12 +0000
Subject: [PATCH] Update unit_quorum_queue_SUITE to use temporary alive &
 registered test queue processes (since we now check/return only alive members
 when fetching replica states)

---
 deps/rabbit/test/unit_quorum_queue_SUITE.erl | 30 ++++++++++++++------
 1 file changed, 21 insertions(+), 9 deletions(-)

diff --git a/deps/rabbit/test/unit_quorum_queue_SUITE.erl b/deps/rabbit/test/unit_quorum_queue_SUITE.erl
index 2f4a7e7133b6..4ca2cf70fd33 100644
--- a/deps/rabbit/test/unit_quorum_queue_SUITE.erl
+++ b/deps/rabbit/test/unit_quorum_queue_SUITE.erl
@@ -7,7 +7,7 @@
 
 all() ->
     [
-     all_replica_states_includes_nonvoters,
+     all_replica_states_includes_alive_nonvoters,
      filter_nonvoters,
      filter_quorum_critical_accounts_nonvoters,
      ra_machine_conf_delivery_limit
@@ -97,27 +97,29 @@ filter_nonvoters(_Config) ->
     [Q4] = rabbit_quorum_queue:filter_promotable(Qs, Ss),
     ok.
 
-all_replica_states_includes_nonvoters(_Config) ->
+all_replica_states_includes_alive_nonvoters(_Config) ->
     ets:new(ra_state, [named_table, public, {write_concurrency, true}]),
+    QPids = start_qprocs(_AliveQs = [q1, q2, q3, q4]),
     ets:insert(ra_state, [
                           {q1, leader, voter},
                           {q2, follower, voter},
                           {q3, follower, promotable},
                           {q4, init, unknown},
-                          %% pre ra-2.7.0
-                          {q5, leader},
-                          {q6, follower}
+                          %% queues in ra_state but not alive
+                          {q5, leader, voter},
+                          {q6, follower, noproc}
                          ]),
     {_, #{
           q1 := leader,
           q2 := follower,
           q3 := promotable,
-          q4 := init,
-          q5 := leader,
-          q6 := follower
-         }} = rabbit_quorum_queue:all_replica_states(),
+          q4 := init
+         } = ReplicaStates} = rabbit_quorum_queue:all_replica_states(),
+    ?assertNot(maps:is_key(q5, ReplicaStates)),
+    ?assertNot(maps:is_key(q6, ReplicaStates)),
 
     true = ets:delete(ra_state),
+    _ = stop_qprocs(QPids),
     ok.
 
 make_ra_machine_conf(Q0, Arg, Pol, OpPol) ->
@@ -128,3 +130,13 @@ make_ra_machine_conf(Q0, Arg, Pol, OpPol) ->
                                           {definition, [{<<"delivery-limit">>,OpPol}]}]),
     rabbit_quorum_queue:ra_machine_config(Q).
 
+start_qprocs(Qs) ->
+    [begin
+        QPid = spawn(fun() -> receive done -> ok end end),
+        erlang:register(Q, QPid),
+        QPid
+     end || Q <- Qs].
+
+stop_qprocs(Pids) ->
+    [erlang:send(P, done)|| P <- Pids].
+