Revert "rabbitmq_ct_broker_helpers: Use node 2 as the cluster seed node"

dumbbell · dumbbell · commit bfa8721cd9d9 · 2025-02-20T19:23:00.000+01:00
This reverts commit c027575.
diff --git a/deps/rabbit/test/cluster_minority_SUITE.erl b/deps/rabbit/test/cluster_minority_SUITE.erl
@@ -133,9 +133,7 @@ init_per_group(Group, Config0) ->
                                                     {rmq_nodes_clustered, false},
                                                     {tcp_ports_base},
                                                     {net_ticktime, 5}]),
-    Config1 = rabbit_ct_helpers:merge_app_env(
-                Config, {rabbit, [{forced_feature_flags_on_init, []}]}),
-    rabbit_ct_helpers:run_steps(Config1,
+    rabbit_ct_helpers:run_steps(Config,
                                 rabbit_ct_broker_helpers:setup_steps() ++
                                     rabbit_ct_client_helpers:setup_steps()).
 
diff --git a/deps/rabbit/test/clustering_events_SUITE.erl b/deps/rabbit/test/clustering_events_SUITE.erl
@@ -87,10 +87,10 @@ configure_cluster_essentials(Config, Group, Clustered) ->
 
 node_added_event(Config) ->
     [Server1, Server2, _Server3] = rabbit_ct_broker_helpers:get_node_configs(Config, nodename),
-    ok = event_recorder:start(Config, Server2),
-    join_cluster(Server1, Server2),
-    E = event_recorder:get_events(Config, Server2),
-    ok = event_recorder:stop(Config, Server2),
+    ok = event_recorder:start(Config),
+    join_cluster(Server2, Server1),
+    E = event_recorder:get_events(Config),
+    ok = event_recorder:stop(Config),
     ?assert(lists:any(fun(#event{type = node_added}) ->
                               true;
                          (_) ->
diff --git a/deps/rabbit/test/clustering_management_SUITE.erl b/deps/rabbit/test/clustering_management_SUITE.erl
@@ -143,15 +143,9 @@ init_per_group(mnesia_store, Config) ->
             Config
     end;
 init_per_group(unclustered_2_nodes, Config) ->
-    Config1 = rabbit_ct_helpers:set_config(
-                Config, [{rmq_nodes_clustered, false}]),
-    rabbit_ct_helpers:merge_app_env(
-      Config1, {rabbit, [{forced_feature_flags_on_init, []}]});
+    rabbit_ct_helpers:set_config(Config, [{rmq_nodes_clustered, false}]);
 init_per_group(unclustered_3_nodes, Config) ->
-    Config1 = rabbit_ct_helpers:set_config(
-                Config, [{rmq_nodes_clustered, false}]),
-    rabbit_ct_helpers:merge_app_env(
-      Config1, {rabbit, [{forced_feature_flags_on_init, []}]});
+    rabbit_ct_helpers:set_config(Config, [{rmq_nodes_clustered, false}]);
 init_per_group(clustered_2_nodes, Config) ->
     rabbit_ct_helpers:set_config(Config, [{rmq_nodes_clustered, true}]);
 init_per_group(clustered_3_nodes, Config) ->
diff --git a/deps/rabbit/test/direct_exchange_routing_v2_SUITE.erl b/deps/rabbit/test/direct_exchange_routing_v2_SUITE.erl
@@ -337,7 +337,7 @@ join_cluster(Config) ->
     Servers0 = [Server1, Server2] = rabbit_ct_broker_helpers:get_node_configs(Config, nodename),
     Servers = lists:sort(Servers0),
 
-    {_Conn1, Ch1} = rabbit_ct_client_helpers:open_connection_and_channel(Config, Server2),
+    {_Conn1, Ch1} = rabbit_ct_client_helpers:open_connection_and_channel(Config, Server1),
     DirectX = <<"amq.direct">>,
     Q = <<"q">>,
     RKey = <<"k">>,
@@ -346,35 +346,35 @@ join_cluster(Config) ->
     bind_queue(Ch1, Q, DirectX, RKey),
 
     %% Server1 and Server2 are not clustered yet.
-    %% Hence, every node has their own table (copy) and only Server2's table contains the binding.
-    ?assertEqual([Server2], index_table_ram_copies(Config, Server2)),
+    %% Hence, every node has their own table (copy) and only Server1's table contains the binding.
     ?assertEqual([Server1], index_table_ram_copies(Config, Server1)),
-    ?assertEqual(1, table_size(Config, ?INDEX_TABLE_NAME, Server2)),
-    ?assertEqual(0, table_size(Config, ?INDEX_TABLE_NAME, Server1)),
+    ?assertEqual([Server2], index_table_ram_copies(Config, Server2)),
+    ?assertEqual(1, table_size(Config, ?INDEX_TABLE_NAME, Server1)),
+    ?assertEqual(0, table_size(Config, ?INDEX_TABLE_NAME, Server2)),
 
-    ok = rabbit_control_helper:command(stop_app, Server1),
-    %% For the purpose of this test it shouldn't matter whether Server1 is reset. Both should work.
+    ok = rabbit_control_helper:command(stop_app, Server2),
+    %% For the purpose of this test it shouldn't matter whether Server2 is reset. Both should work.
     case erlang:system_time() rem 2 of
         0 ->
-            ok = rabbit_control_helper:command(reset, Server1);
+            ok = rabbit_control_helper:command(reset, Server2);
         1 ->
             ok
     end,
-    ok = rabbit_control_helper:command(join_cluster, Server1, [atom_to_list(Server2)], []),
-    ok = rabbit_control_helper:command(start_app, Server1),
+    ok = rabbit_control_helper:command(join_cluster, Server2, [atom_to_list(Server1)], []),
+    ok = rabbit_control_helper:command(start_app, Server2),
 
-    %% After Server1 joined Server2, the table should be clustered.
-    ?assertEqual(Servers, index_table_ram_copies(Config, Server1)),
-    ?assertEqual(1, table_size(Config, ?INDEX_TABLE_NAME, Server1)),
+    %% After Server2 joined Server1, the table should be clustered.
+    ?assertEqual(Servers, index_table_ram_copies(Config, Server2)),
+    ?assertEqual(1, table_size(Config, ?INDEX_TABLE_NAME, Server2)),
 
-    %% Publishing via Server2 via "direct exchange routing v2" should work.
+    %% Publishing via Server1 via "direct exchange routing v2" should work.
     amqp_channel:call(Ch1, #'confirm.select'{}),
     amqp_channel:register_confirm_handler(Ch1, self()),
     publish(Ch1, DirectX, RKey),
     assert_confirm(),
 
-    %% Publishing via Server1 via "direct exchange routing v2" should work.
-    {_Conn2, Ch2} = rabbit_ct_client_helpers:open_connection_and_channel(Config, Server1),
+    %% Publishing via Server2 via "direct exchange routing v2" should work.
+    {_Conn2, Ch2} = rabbit_ct_client_helpers:open_connection_and_channel(Config, Server2),
     amqp_channel:call(Ch2, #'confirm.select'{}),
     amqp_channel:register_confirm_handler(Ch2, self()),
     publish(Ch2, DirectX, RKey),
diff --git a/deps/rabbit/test/event_recorder.erl b/deps/rabbit/test/event_recorder.erl
@@ -16,9 +16,9 @@
          handle_event/2,
          handle_call/2]).
 %% client API
--export([start/1, start/2,
-         stop/1, stop/2,
-         get_events/1, get_events/2]).
+-export([start/1,
+         stop/1,
+         get_events/1]).
 -export([assert_event_type/2,
          assert_event_prop/2]).
 
@@ -42,31 +42,22 @@ handle_call(take_state, State) ->
     {ok, lists:reverse(State), ?INIT_STATE}.
 
 start(Config) ->
-    start(Config, 0).
-
-start(Config, Node) ->
     ok = rabbit_ct_broker_helpers:add_code_path_to_all_nodes(Config, ?MODULE),
-    ok = gen_event:add_handler(event_manager_ref(Config, Node), ?MODULE, []).
+    ok = gen_event:add_handler(event_manager_ref(Config), ?MODULE, []).
 
 stop(Config) ->
-    stop(Config, 0).
-
-stop(Config, Node) ->
-    ok = gen_event:delete_handler(event_manager_ref(Config, Node), ?MODULE, []).
+    ok = gen_event:delete_handler(event_manager_ref(Config), ?MODULE, []).
 
 get_events(Config) ->
-    get_events(Config, 0).
-
-get_events(Config, Node) ->
     %% events are sent and processed asynchronously
     timer:sleep(500),
-    Result = gen_event:call(event_manager_ref(Config, Node), ?MODULE, take_state),
+    Result = gen_event:call(event_manager_ref(Config), ?MODULE, take_state),
     ?assert(is_list(Result)),
     Result.
 
-event_manager_ref(Config, Node) ->
-    Node1 = get_node_config(Config, Node, nodename),
-    {rabbit_event, Node1}.
+event_manager_ref(Config) ->
+    Node = get_node_config(Config, 0, nodename),
+    {rabbit_event, Node}.
 
 assert_event_type(ExpectedType, #event{type = ActualType}) ->
     ?assertEqual(ExpectedType, ActualType).
diff --git a/deps/rabbit/test/feature_flags_SUITE.erl b/deps/rabbit/test/feature_flags_SUITE.erl
@@ -192,9 +192,7 @@ init_per_group(clustering, Config) ->
                 [{rmq_nodes_count, 2},
                  {rmq_nodes_clustered, false},
                  {start_rmq_with_plugins_disabled, true}]),
-    Config2 = rabbit_ct_helpers:merge_app_env(
-                Config1, {rabbit, [{forced_feature_flags_on_init, []}]}),
-    rabbit_ct_helpers:run_setup_steps(Config2, [fun prepare_my_plugin/1]);
+    rabbit_ct_helpers:run_setup_steps(Config1, [fun prepare_my_plugin/1]);
 init_per_group(activating_plugin, Config) ->
     Config1 = rabbit_ct_helpers:set_config(
                 Config,
@@ -208,17 +206,7 @@ init_per_group(_, Config) ->
 end_per_group(_, Config) ->
     Config.
 
-init_per_testcase(enable_feature_flag_when_ff_file_is_unwritable = Testcase, Config) ->
-    case erlang:system_info(otp_release) of
-        "26" ->
-            {skip, "Hits a crash in Mnesia fairly frequently"};
-        _ ->
-            do_init_per_testcase(Testcase, Config)
-    end;
 init_per_testcase(Testcase, Config) ->
-    do_init_per_testcase(Testcase, Config).
-
-do_init_per_testcase(Testcase, Config) ->
     rabbit_ct_helpers:testcase_started(Config, Testcase),
     TestNumber = rabbit_ct_helpers:testcase_number(Config, ?MODULE, Testcase),
     Config1 = case Testcase of
@@ -897,7 +885,7 @@ clustering_ok_with_ff_enabled_on_some_nodes(Config) ->
             ok
     end,
 
-    ?assertEqual(Config, rabbit_ct_broker_helpers:cluster_nodes(Config, 0)),
+    ?assertEqual(Config, rabbit_ct_broker_helpers:cluster_nodes(Config)),
 
     log_feature_flags_of_all_nodes(Config),
     case FFSubsysOk of
@@ -993,7 +981,7 @@ clustering_denied_with_new_ff_enabled(Config) ->
         false -> ok
     end,
 
-    ?assertMatch({skip, _}, rabbit_ct_broker_helpers:cluster_nodes(Config, 0)),
+    ?assertMatch({skip, _}, rabbit_ct_broker_helpers:cluster_nodes(Config)),
 
     log_feature_flags_of_all_nodes(Config),
     case FFSubsysOk of
@@ -1055,7 +1043,7 @@ clustering_ok_with_new_ff_enabled_from_plugin_on_some_nodes(Config) ->
         false -> ok
     end,
 
-    ?assertEqual(Config, rabbit_ct_broker_helpers:cluster_nodes(Config, 0)),
+    ?assertEqual(Config, rabbit_ct_broker_helpers:cluster_nodes(Config)),
 
     log_feature_flags_of_all_nodes(Config),
     case FFSubsysOk of
diff --git a/deps/rabbit/test/peer_discovery_classic_config_SUITE.erl b/deps/rabbit/test/peer_discovery_classic_config_SUITE.erl
@@ -91,7 +91,6 @@ init_per_testcase(successful_discovery = Testcase, Config) ->
     NodeNamesWithHostname = [rabbit_nodes:make({Name, "localhost"}) || Name <- NodeNames],
     Config3 = rabbit_ct_helpers:merge_app_env(Config2,
       {rabbit, [
-          {forced_feature_flags_on_init, []},
           {cluster_nodes, {NodeNamesWithHostname, disc}},
           {cluster_formation, [
               {internal_lock_retries, 10}
@@ -125,7 +124,6 @@ init_per_testcase(successful_discovery_with_a_subset_of_nodes_coming_online = Te
     %% unreachable nodes vs ~6min without them
     Config3 = rabbit_ct_helpers:merge_app_env(Config2,
       {rabbit, [
-          {forced_feature_flags_on_init, []},
           {cluster_nodes, {NodeNamesWithHostname, disc}},
           {cluster_formation, [
               {internal_lock_retries, 10}
@@ -143,7 +141,6 @@ init_per_testcase(no_nodes_configured = Testcase, Config) ->
       ]),
     Config3 = rabbit_ct_helpers:merge_app_env(Config2,
       {rabbit, [
-          {forced_feature_flags_on_init, []},
           {cluster_nodes, {[], disc}},
           {cluster_formation, [
               {internal_lock_retries, 10}
diff --git a/deps/rabbit/test/quorum_queue_member_reconciliation_SUITE.erl b/deps/rabbit/test/quorum_queue_member_reconciliation_SUITE.erl
@@ -81,7 +81,7 @@ merge_app_env(Config) ->
 end_per_testcase(Testcase, Config) ->
     [Server0, Server1, Server2] =
         rabbit_ct_broker_helpers:get_node_configs(Config, nodename),
-    reset_nodes([Server2, Server0], Server1),
+    reset_nodes([Server1, Server2], Server0),
     Config1 = rabbit_ct_helpers:run_steps(
                 Config,
                 rabbit_ct_client_helpers:teardown_steps()),
@@ -107,83 +107,83 @@ reset_nodes([Node| Nodes], Leader) ->
 auto_grow(Config) ->
     [Server0, Server1, Server2] =
         rabbit_ct_broker_helpers:get_node_configs(Config, nodename),
-    Ch = rabbit_ct_client_helpers:open_channel(Config, Server1),
+    Ch = rabbit_ct_client_helpers:open_channel(Config, Server0),
 
     QQ = ?config(queue_name, Config),
     ?assertEqual({'queue.declare_ok', QQ, 0, 0},
                  declare(Ch, QQ, [{<<"x-queue-type">>, longstr, <<"quorum">>}])),
 
     %% There is only one node in the cluster at the moment
-    {ok, Members, _} = ra:members({queue_utils:ra_name(QQ), Server1}),
+    {ok, Members, _} = ra:members({queue_utils:ra_name(QQ), Server0}),
     ?assertEqual(1, length(Members)),
 
-    add_server_to_cluster(Server0, Server1),
+    add_server_to_cluster(Server1, Server0),
     %% With 2 nodes in the cluster, target group size is not reached, so no
     %% new members should be available. We sleep a while so the periodic check
     %% runs
     timer:sleep(4000),
-    {ok, Members, _} = ra:members({queue_utils:ra_name(QQ), Server1}),
+    {ok, Members, _} = ra:members({queue_utils:ra_name(QQ), Server0}),
     ?assertEqual(1, length(Members)),
 
-    add_server_to_cluster(Server2, Server1),
+    add_server_to_cluster(Server2, Server0),
     %% With 3 nodes in the cluster, target size is met so eventually it should
     %% be 3 members
     wait_until(fun() ->
-                       {ok, M, _} = ra:members({queue_utils:ra_name(QQ), Server1}),
+                       {ok, M, _} = ra:members({queue_utils:ra_name(QQ), Server0}),
                        3 =:= length(M)
                end).
 
 auto_grow_drained_node(Config) ->
     [Server0, Server1, Server2] =
         rabbit_ct_broker_helpers:get_node_configs(Config, nodename),
-    Ch = rabbit_ct_client_helpers:open_channel(Config, Server1),
+    Ch = rabbit_ct_client_helpers:open_channel(Config, Server0),
 
     QQ = ?config(queue_name, Config),
     ?assertEqual({'queue.declare_ok', QQ, 0, 0},
                  declare(Ch, QQ, [{<<"x-queue-type">>, longstr, <<"quorum">>}])),
 
     %% There is only one node in the cluster at the moment
-    {ok, Members, _} = ra:members({queue_utils:ra_name(QQ), Server1}),
+    {ok, Members, _} = ra:members({queue_utils:ra_name(QQ), Server0}),
     ?assertEqual(1, length(Members)),
 
-    add_server_to_cluster(Server0, Server1),
-    %% mark Server0 as drained, which should mean the node is not a candiate
+    add_server_to_cluster(Server1, Server0),
+    %% mark server1 as drained, which should mean the node is not a candiate
     %% for qq membership
-    rabbit_ct_broker_helpers:mark_as_being_drained(Config, Server0),
+    rabbit_ct_broker_helpers:mark_as_being_drained(Config, Server1),
     rabbit_ct_helpers:await_condition(
-        fun () -> rabbit_ct_broker_helpers:is_being_drained_local_read(Config, Server0) end,
+        fun () -> rabbit_ct_broker_helpers:is_being_drained_local_read(Config, Server1) end,
         10000),
-    add_server_to_cluster(Server2, Server1),
+    add_server_to_cluster(Server2, Server0),
     timer:sleep(5000),
     %% We have 3 nodes, but one is drained, so it will not be concidered.
-    {ok, Members1, _} = ra:members({queue_utils:ra_name(QQ), Server1}),
+    {ok, Members1, _} = ra:members({queue_utils:ra_name(QQ), Server0}),
     ?assertEqual(1, length(Members1)),
 
-    rabbit_ct_broker_helpers:unmark_as_being_drained(Config, Server0),
+    rabbit_ct_broker_helpers:unmark_as_being_drained(Config, Server1),
     rabbit_ct_helpers:await_condition(
-        fun () -> not rabbit_ct_broker_helpers:is_being_drained_local_read(Config, Server0) end,
+        fun () -> not rabbit_ct_broker_helpers:is_being_drained_local_read(Config, Server1) end,
         10000),
     %% We have 3 nodes, none is being drained, so we should grow membership to 3
     wait_until(fun() ->
-                       {ok, M, _} = ra:members({queue_utils:ra_name(QQ), Server1}),
+                       {ok, M, _} = ra:members({queue_utils:ra_name(QQ), Server0}),
                        3 =:= length(M)
                end).
 
 
 auto_shrink(Config) ->
     [Server0, Server1, Server2] =
         rabbit_ct_broker_helpers:get_node_configs(Config, nodename),
-    Ch = rabbit_ct_client_helpers:open_channel(Config, Server1),
-    add_server_to_cluster(Server0, Server1),
-    add_server_to_cluster(Server2, Server1),
+    Ch = rabbit_ct_client_helpers:open_channel(Config, Server0),
+    add_server_to_cluster(Server1, Server0),
+    add_server_to_cluster(Server2, Server0),
 
     QQ = ?config(queue_name, Config),
     ?assertEqual({'queue.declare_ok', QQ, 0, 0},
                  declare(Ch, QQ, [{<<"x-queue-type">>, longstr, <<"quorum">>}])),
 
     wait_until(fun() ->
                        {ok, M, _} = ra:members({queue_utils:ra_name(QQ),
-                                                Server1}),
+                                                Server0}),
                        3 =:= length(M)
                end),
     ok = rabbit_control_helper:command(stop_app, Server2),
@@ -192,7 +192,7 @@ auto_shrink(Config) ->
     %% with one node 'forgotten', eventually the membership will shrink to 2
     wait_until(fun() ->
                        {ok, M, _} = ra:members({queue_utils:ra_name(QQ),
-                                                Server1}),
+                                                Server0}),
                        2 =:= length(M)
                end).
 
diff --git a/deps/rabbit/test/rabbit_stream_queue_SUITE.erl b/deps/rabbit/test/rabbit_stream_queue_SUITE.erl
@@ -237,9 +237,7 @@ init_per_group1(Group, Config) ->
                    _ ->
                        Config1
                end,
-    Config1c = rabbit_ct_helpers:merge_app_env(
-                 Config1b, {rabbit, [{forced_feature_flags_on_init, []}]}),
-    Ret = rabbit_ct_helpers:run_steps(Config1c,
+    Ret = rabbit_ct_helpers:run_steps(Config1b,
                                       [fun merge_app_env/1 ] ++
                                       rabbit_ct_broker_helpers:setup_steps()),
     case Ret of
diff --git a/deps/rabbitmq_ct_helpers/src/rabbit_ct_broker_helpers.erl b/deps/rabbitmq_ct_helpers/src/rabbit_ct_broker_helpers.erl
diff --git a/deps/rabbitmq_mqtt/test/mqtt_shared_SUITE.erl b/deps/rabbitmq_mqtt/test/mqtt_shared_SUITE.erl
diff --git a/deps/rabbitmq_peer_discovery_consul/test/system_SUITE.erl b/deps/rabbitmq_peer_discovery_consul/test/system_SUITE.erl
diff --git a/deps/rabbitmq_peer_discovery_etcd/test/system_SUITE.erl b/deps/rabbitmq_peer_discovery_etcd/test/system_SUITE.erl
