Unit test rabbit_db_exchange and API updates

Author: dcorbacho

deps/rabbit/BUILD.bazel

@@ -1118,6 +1118,11 @@ rabbitmq_integration_suite(
     size = "small",
 )
 
+rabbitmq_integration_suite(
+    name = "unit_rabbit_db_exchange_SUITE",
+    size = "small",
+)
+
 assert_suites()
 
 filegroup(

deps/rabbit/src/rabbit_db_binding.erl

@@ -28,6 +28,9 @@
 
 -export([create_index_route_table/0]).
 
+%% For testing
+-export([clear/0]).
+
 %% -------------------------------------------------------------------
 %% exists().
 %% -------------------------------------------------------------------
@@ -60,8 +63,7 @@ exists_in_mnesia(Binding) ->
       Binding :: rabbit_types:binding(),
       Src :: rabbit_types:r('exchange'),
       Dst :: rabbit_types:r('exchange') | rabbit_types:r('queue'),
-      BindingType :: durable | semi_durable | transient,
-      ChecksFun :: fun((Src, Dst) -> {ok, BindingType} | {error, Reason :: any()}),
+      ChecksFun :: fun((Src, Dst) -> ok | {error, Reason :: any()}),
       Ret :: ok | {error, Reason :: any()}.
 %% @doc Writes a binding if it doesn't exist already and passes the validation in
 %% `ChecksFun` i.e. exclusive access
@@ -83,8 +85,7 @@ create(Binding, ChecksFun) ->
       Binding :: rabbit_types:binding(),
       Src :: rabbit_types:r('exchange'),
       Dst :: rabbit_types:r('exchange') | rabbit_types:r('queue'),
-      BindingType :: durable | semi_durable | transient,
-      ChecksFun :: fun((Src, Dst) -> {ok, BindingType} | {error, Reason :: any()}),
+      ChecksFun :: fun((Src, Dst) -> ok | {error, Reason :: any()}),
       Ret :: ok | {error, Reason :: any()}.
 %% @doc Deletes a binding record from the database if it passes the validation in
 %% `ChecksFun`. It also triggers the deletion of auto-delete exchanges if needed.
@@ -557,7 +558,7 @@ recover_semi_durable_route(#route{binding = B} = Route, X) ->
 serial_in_mnesia(false, _) ->
     none;
 serial_in_mnesia(true, X) ->
-    rabbit_db_exchange:next_serial_in_mnesia_tx(X).
+    rabbit_db_exchange:next_serial_in_mnesia_tx(X#exchange.name).
 
 sync_route(Route, durable, ShouldIndexTable, Fun) ->
     ok = Fun(rabbit_durable_route, Route, write),
@@ -621,6 +622,25 @@ continue('$end_of_table')    -> false;
 continue({[_|_], _})         -> true;
 continue({[], Continuation}) -> continue(mnesia:select(Continuation)).
 
+%% -------------------------------------------------------------------
+%% clear().
+%% -------------------------------------------------------------------
+
+-spec clear() -> ok.
+%% @doc Deletes all bindings.
+%%
+%% @private
+
+clear() ->
+    rabbit_db:run(
+      #{mnesia => fun() -> clear_in_mnesia() end}).
+
+clear_in_mnesia() ->
+    mnesia:clear_table(rabbit_route),
+    mnesia:clear_table(rabbit_durable_route),
+    mnesia:clear_table(rabbit_reverse_route),
+    mnesia:clear_table(rabbit_index_route).
+
 %% Routing. Hot code path
 %% -------------------------------------------------------------------------
 route_in_mnesia_v1(SrcName, [RoutingKey]) ->