Skip to content

Commit 7a12cf8

Browse files
committed
Adapt plugins to new exchange and exchange decorator API
1 parent c95ac0a commit 7a12cf8

File tree

5 files changed

+21
-24
lines changed

5 files changed

+21
-24
lines changed

deps/rabbit/src/rabbit_exchange_decorator.erl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,5 +109,5 @@ maybe_recover(X = #exchange{name = Name,
109109
Old -> ok;
110110
_ -> %% TODO create a tx here for non-federation decorators
111111
_ = [M:create(none, X) || M <- New -- Old],
112-
rabbit_exchange:update_decorators(Name)
112+
rabbit_exchange:update_decorators(Name, Decs1)
113113
end.

deps/rabbitmq_event_exchange/src/rabbit_event_exchange_decorator.erl

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
-behaviour(rabbit_exchange_decorator).
2222

2323
-export([description/0, serialise_events/1]).
24-
-export([create/2, delete/3, policy_changed/2,
24+
-export([create/2, delete/2, policy_changed/2,
2525
add_binding/3, remove_bindings/3, route/2, active_for/1]).
2626

2727
description() ->
@@ -32,13 +32,13 @@ serialise_events(_) -> false.
3232
create(_, _) ->
3333
ok.
3434

35-
delete(_, _, _) ->
35+
delete(_, _) ->
3636
ok.
3737

3838
policy_changed(_, _) ->
3939
ok.
4040

41-
add_binding(transaction, #exchange{name = #resource{name = ?EXCH_NAME} = Name},
41+
add_binding(none, #exchange{name = #resource{name = ?EXCH_NAME} = Name},
4242
_Bs) ->
4343
case rabbit_binding:list_for_source(Name) of
4444
[_] ->
@@ -47,10 +47,10 @@ add_binding(transaction, #exchange{name = #resource{name = ?EXCH_NAME} = Name},
4747
_ ->
4848
ok
4949
end;
50-
add_binding(_, _X, _Bs) ->
50+
add_binding(_, _, _) ->
5151
ok.
5252

53-
remove_bindings(transaction, #exchange{name = #resource{name = ?EXCH_NAME} = Name},
53+
remove_bindings(none, #exchange{name = #resource{name = ?EXCH_NAME} = Name},
5454
_Bs) ->
5555
case rabbit_binding:list_for_source(Name) of
5656
[] ->
@@ -59,7 +59,7 @@ remove_bindings(transaction, #exchange{name = #resource{name = ?EXCH_NAME} = Nam
5959
_ ->
6060
ok
6161
end;
62-
remove_bindings(_, _X, _Bs) ->
62+
remove_bindings(_, _, _) ->
6363
ok.
6464

6565
route(_, _) -> [].

deps/rabbitmq_random_exchange/src/rabbit_exchange_type_random.erl

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
add_binding/3,
2121
assert_args_equivalence/2,
2222
create/2,
23-
delete/3,
23+
delete/2,
2424
policy_changed/2,
2525
description/0,
2626
recover/2,
@@ -49,12 +49,12 @@ info(_X) -> [].
4949
info(_X, _) -> [].
5050
serialise_events() -> false.
5151
validate(_X) -> ok.
52-
create(_Tx, _X) -> ok.
52+
create(_Serial, _X) -> ok.
5353
recover(_X, _Bs) -> ok.
54-
delete(_Tx, _X, _Bs) -> ok.
54+
delete(_Serial, _X) -> ok.
5555
policy_changed(_X1, _X2) -> ok.
56-
add_binding(_Tx, _X, _B) -> ok.
57-
remove_bindings(_Tx, _X, _Bs) -> ok.
56+
add_binding(_Serial, _X, _B) -> ok.
57+
remove_bindings(_Serial, _X, _Bs) -> ok.
5858
validate_binding(_X, _B) -> ok.
5959
assert_args_equivalence(X, Args) ->
6060
rabbit_exchange:assert_args_equivalence(X, Args).

deps/rabbitmq_sharding/src/rabbit_sharding_exchange_decorator.erl

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
-behaviour(rabbit_exchange_decorator).
2121

2222
-export([description/0, serialise_events/1]).
23-
-export([create/2, delete/3, policy_changed/2,
23+
-export([create/2, delete/2, policy_changed/2,
2424
add_binding/3, remove_bindings/3, route/2, active_for/1]).
2525

2626
-import(rabbit_sharding_util, [shard/1]).
@@ -32,14 +32,12 @@ description() ->
3232

3333
serialise_events(_X) -> false.
3434

35-
create(transaction, _X) ->
36-
ok;
3735
create(none, X) ->
3836
_ = maybe_start_sharding(X),
3937
ok.
4038

41-
add_binding(_Tx, _X, _B) -> ok.
42-
remove_bindings(_Tx, _X, _Bs) -> ok.
39+
add_binding(_Serial, _X, _B) -> ok.
40+
remove_bindings(_Serial, _X, _Bs) -> ok.
4341

4442
route(_, _) -> [].
4543

@@ -50,8 +48,7 @@ active_for(X) ->
5048
end.
5149

5250
%% we have to remove the policy from ?SHARDING_TABLE
53-
delete(transaction, _X, _Bs) -> ok;
54-
delete(none, X, _Bs) ->
51+
delete(none, X) ->
5552
_ = maybe_stop_sharding(X),
5653
ok.
5754

deps/rabbitmq_sharding/src/rabbit_sharding_exchange_type_modulus_hash.erl

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313

1414
-export([description/0, serialise_events/0, route/2, info/1, info/2]).
1515
-export([validate/1, validate_binding/2,
16-
create/2, delete/3, policy_changed/2,
16+
create/2, delete/2, policy_changed/2,
1717
add_binding/3, remove_bindings/3, assert_args_equivalence/2]).
1818

1919
-rabbit_boot_step(
@@ -47,11 +47,11 @@ info(_, _) -> [].
4747

4848
validate(_X) -> ok.
4949
validate_binding(_X, _B) -> ok.
50-
create(_Tx, _X) -> ok.
51-
delete(_Tx, _X, _Bs) -> ok.
50+
create(_Serial, _X) -> ok.
51+
delete(_Serial, _X) -> ok.
5252
policy_changed(_X1, _X2) -> ok.
53-
add_binding(_Tx, _X, _B) -> ok.
54-
remove_bindings(_Tx, _X, _Bs) -> ok.
53+
add_binding(_Serial, _X, _B) -> ok.
54+
remove_bindings(_Serial, _X, _Bs) -> ok.
5555
assert_args_equivalence(X, Args) ->
5656
rabbit_exchange:assert_args_equivalence(X, Args).
5757

0 commit comments

Comments
 (0)