Skip to content

Commit 65d0977

Browse files
Remove a few remaining mentions of global prefetch
As suggested in #12454.
1 parent a15e1bf commit 65d0977

File tree

5 files changed

+6
-19
lines changed

5 files changed

+6
-19
lines changed

deps/rabbit/src/rabbit_channel.erl

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -184,7 +184,6 @@
184184
acks_uncommitted,
185185
pending_raft_commands,
186186
prefetch_count,
187-
global_prefetch_count,
188187
state,
189188
garbage_collection]).
190189

@@ -2272,8 +2271,6 @@ i(pending_raft_commands, #ch{queue_states = QS}) ->
22722271
i(state, #ch{cfg = #conf{state = running}}) -> credit_flow:state();
22732272
i(state, #ch{cfg = #conf{state = State}}) -> State;
22742273
i(prefetch_count, #ch{cfg = #conf{consumer_prefetch = C}}) -> C;
2275-
i(global_prefetch_count, #ch{limiter = Limiter}) ->
2276-
rabbit_limiter:get_prefetch_limit(Limiter);
22772274
i(interceptors, #ch{interceptor_state = IState}) ->
22782275
IState;
22792276
i(garbage_collection, _State) ->

deps/rabbitmq_cli/lib/rabbitmq/cli/ctl/commands/list_channels_command.ex

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ defmodule RabbitMQ.CLI.Ctl.Commands.ListChannelsCommand do
1616
@info_keys ~w(pid connection name number user vhost transactional
1717
confirm consumer_count messages_unacknowledged
1818
messages_uncommitted acks_uncommitted messages_unconfirmed
19-
prefetch_count global_prefetch_count)a
19+
prefetch_count)a
2020

2121
def info_keys(), do: @info_keys
2222

deps/rabbitmq_management/priv/www/js/tmpl/channel.ejs

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -38,10 +38,6 @@
3838
<th>Prefetch count</th>
3939
<td><%= channel.prefetch_count %></td>
4040
</tr>
41-
<tr>
42-
<th>Global prefetch count</th>
43-
<td><%= channel.global_prefetch_count %></td>
44-
</tr>
4541
</table>
4642

4743
<table class="facts">

deps/rabbitmq_management/priv/www/js/tmpl/channels-list.ejs

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -157,9 +157,6 @@
157157
<% if (channel.prefetch_count != 0) { %>
158158
<%= channel.prefetch_count %><br/>
159159
<% } %>
160-
<% if (channel.global_prefetch_count != 0) { %>
161-
<%= channel.global_prefetch_count %> (global)
162-
<% } %>
163160
</td>
164161
<% } %>
165162
<% if (show_column('channels', 'msgs-unacked')) { %>

deps/rabbitmq_prometheus/src/collectors/prometheus_rabbitmq_core_metrics_collector.erl

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -169,8 +169,7 @@
169169
{2, undefined, channel_messages_unconfirmed, gauge, "Published but not yet confirmed messages", messages_unconfirmed},
170170
{2, undefined, channel_messages_uncommitted, gauge, "Messages received in a transaction but not yet committed", messages_uncommitted},
171171
{2, undefined, channel_acks_uncommitted, gauge, "Message acknowledgements in a transaction not yet committed", acks_uncommitted},
172-
{2, undefined, consumer_prefetch, gauge, "Limit of unacknowledged messages for each consumer", prefetch_count},
173-
{2, undefined, channel_prefetch, gauge, "Total limit of unacknowledged messages for all consumers on a channel", global_prefetch_count}
172+
{2, undefined, consumer_prefetch, gauge, "Limit of unacknowledged messages for each consumer", prefetch_count}
174173
]},
175174

176175
{channel_exchange_metrics, [
@@ -564,20 +563,18 @@ get_data(connection_metrics = Table, false, _) ->
564563
end, empty(Table), Table),
565564
[{Table, [{recv_cnt, A1}, {send_cnt, A2}, {send_pend, A3}, {channels, A4}]}];
566565
get_data(channel_metrics = Table, false, _) ->
567-
{Table, A1, A2, A3, A4, A5, A6, A7} =
568-
ets:foldl(fun({_, Props}, {T, A1, A2, A3, A4, A5, A6, A7}) ->
566+
{Table, A1, A2, A3, A4, A5, A6} =
567+
ets:foldl(fun({_, Props}, {T, A1, A2, A3, A4, A5, A6}) ->
569568
{T,
570569
sum(proplists:get_value(consumer_count, Props), A1),
571570
sum(proplists:get_value(messages_unacknowledged, Props), A2),
572571
sum(proplists:get_value(messages_unconfirmed, Props), A3),
573572
sum(proplists:get_value(messages_uncommitted, Props), A4),
574573
sum(proplists:get_value(acks_uncommitted, Props), A5),
575-
sum(proplists:get_value(prefetch_count, Props), A6),
576-
sum(proplists:get_value(global_prefetch_count, Props), A7)}
574+
sum(proplists:get_value(prefetch_count, Props), A6)}
577575
end, empty(Table), Table),
578576
[{Table, [{consumer_count, A1}, {messages_unacknowledged, A2}, {messages_unconfirmed, A3},
579-
{messages_uncommitted, A4}, {acks_uncommitted, A5}, {prefetch_count, A6},
580-
{global_prefetch_count, A7}]}];
577+
{messages_uncommitted, A4}, {acks_uncommitted, A5}, {prefetch_count, A6}]}];
581578
get_data(queue_consumer_count = MF, false, VHostsFilter) ->
582579
Table = queue_metrics, %% Real table name
583580
{_, A1} = ets:foldl(fun

0 commit comments

Comments
 (0)