Use atomic utilities instead of synchronization in stats #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All the counters are converted to AtomicLong instead of regular, non-volatile properties updated and read in synchronized blocks. This avoids a lot of locking. The Stats class has also been refactored to use nano time instead of the current time, which is more appropriate and more accurate to measure intervals.
pivotal-rabbitmq-ci
pushed a commit
that referenced
this pull request
Oct 7, 2022
Use atomic utilities instead of synchronization in stats
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the counters are converted to AtomicLong instead of regular, non-volatile properties updated and read in synchronized blocks. This avoids a lot of locking.
The Stats class has also been refactored to use nano time instead of the current time, which is more appropriate and more accurate to measure intervals.