Use millisecond granularity for publisher ramp-up period #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was seconds, which works for very long ramp-up period (e.g. 60 seconds or more) and a small number of publishers (few 100s), but not short ramp-up period and large numbers of publishers (start 5000 publishers in 15 seconds). In such cases, the workload was not random enough like in real-life and metrics like publisher confirm latency could be much higher than expected. References #394
pivotal-rabbitmq-ci
pushed a commit
that referenced
this pull request
Oct 5, 2022
Use millisecond granularity for publisher ramp-up period
acogoluegnes
added a commit
that referenced
this pull request
Oct 6, 2022
Use a default 1 second random start delay when producer rate instructions are specified. Use the one specified by the user (including 0, meaning no delay) otherwise. References #401
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was seconds, which works for very long ramp-up period (e.g. 60 seconds or more) and a small number of publishers (few 100s), but not short ramp-up period and large numbers of publishers (start 5000 publishers in 15 seconds). In such cases, the workload was not random enough like in real-life and metrics like publisher confirm latency could be much higher than expected.
References #394