Review Roslyn analyzers

[lukebakken]

https://devblogs.microsoft.com/dotnet/configureawait-faq/
https://docs.microsoft.com/en-us/visualstudio/code-quality/ca2007?view=vs-2019
dotnet/roslyn-analyzers#6757

[lukebakken]

Example of what an analyzer might catch: #1347 (comment)

[lukebakken]

These should eventually be enabled:

dotnet_diagnostic.RS0026.severity = none
dotnet_diagnostic.RS0027.severity = none
dotnet_diagnostic.RS0036.severity = none
dotnet_diagnostic.RS0041.severity = none

[lukebakken]

Related old issue - #444

[lukebakken]

https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca2007

[lukebakken]

dotnet/roslyn-analyzers#6757