Merge pull request #846 from Pliner/drop-unused-use-background-threads-for-io

Deletion of unused UseBackgroundThreadsForIO

Author: michaelklishin

projects/RabbitMQ.Client/client/api/ConnectionFactory.cs

@@ -298,11 +298,6 @@ public AmqpTcpEndpoint Endpoint
         /// </summary>
         public TimeSpan RequestedHeartbeat { get; set; } = DefaultHeartbeat;
 
-        /// <summary>
-        /// When set to true, background thread will be used for the I/O loop.
-        /// </summary>
-        public bool UseBackgroundThreadsForIO { get; set; }
-
         /// <summary>
         /// Username to use when authenticating to the server.
         /// </summary>

projects/RabbitMQ.Client/client/api/IConnectionFactory.cs

@@ -72,11 +72,6 @@ public interface IConnectionFactory
         /// </summary>
         TimeSpan RequestedHeartbeat { get; set; }
 
-        /// <summary>
-        /// When set to true, background threads will be used for I/O and heartbeats.
-        /// </summary>
-        bool UseBackgroundThreadsForIO { get; set; }
-
         /// <summary>
         /// Username to use when authenticating to the server.
         /// </summary>

projects/RabbitMQ.Client/client/impl/Connection.cs

@@ -124,7 +124,7 @@ public Connection(IConnectionFactory factory, bool insist, IFrameHandler frameHa
             _session0 = new MainSession(this) { Handler = NotifyReceivedCloseOk };
             _model0 = (ModelBase)Protocol.CreateModel(_session0);
 
-            StartMainLoop(factory.UseBackgroundThreadsForIO);
+            StartMainLoop();
             Open(insist);
         }
 
@@ -830,7 +830,7 @@ public void MaybeStartHeartbeatTimers()
             }
         }
 
-        public void StartMainLoop(bool useBackgroundThread)
+        public void StartMainLoop()
         {
             _mainLoopTask = Task.Run((Action)MainLoop);
         }

projects/Unit/APIApproval.Approve.verified.txt

@@ -90,7 +90,6 @@ namespace RabbitMQ.Client
         public RabbitMQ.Client.SslOption Ssl { get; set; }
         public bool TopologyRecoveryEnabled { get; set; }
         public System.Uri Uri { get; set; }
-        public bool UseBackgroundThreadsForIO { get; set; }
         public string UserName { get; set; }
         public string VirtualHost { get; set; }
         public static System.Net.Sockets.AddressFamily DefaultAddressFamily { get; set; }
@@ -330,7 +329,6 @@ namespace RabbitMQ.Client
         uint RequestedFrameMax { get; set; }
         System.TimeSpan RequestedHeartbeat { get; set; }
         System.Uri Uri { get; set; }
-        bool UseBackgroundThreadsForIO { get; set; }
         string UserName { get; set; }
         string VirtualHost { get; set; }
         RabbitMQ.Client.IAuthMechanismFactory AuthMechanismFactory(System.Collections.Generic.IList<string> mechanismNames);