Add TODOs

lukebakken · lukebakken · commit 4d261b614c83 · 2023-12-04T13:16:28.000-08:00
diff --git a/projects/RabbitMQ.Client/client/impl/AutorecoveringConnection.Recovery.cs b/projects/RabbitMQ.Client/client/impl/AutorecoveringConnection.Recovery.cs
@@ -226,7 +226,6 @@ await RecoverChannelsAndItsConsumersAsync(recordedEntitiesSemaphoreHeld: true)
             return false;
         }
 
-        // TODO cancellation token
         private async ValueTask<bool> TryRecoverConnectionDelegateAsync(CancellationToken cancellationToken)
         {
             try
diff --git a/projects/RabbitMQ.Client/client/impl/Connection.Commands.cs b/projects/RabbitMQ.Client/client/impl/Connection.Commands.cs
@@ -69,14 +69,17 @@ internal void HandleConnectionUnblocked()
             }
         }
 
+        // TODO cancellationToken
         private async ValueTask StartAndTuneAsync()
         {
             var connectionStartCell = new TaskCompletionSource<ConnectionStartDetails>(TaskCreationOptions.RunContinuationsAsynchronously);
             _channel0.m_connectionStartCell = connectionStartCell;
             _channel0.HandshakeContinuationTimeout = _config.HandshakeContinuationTimeout;
             _frameHandler.ReadTimeout = _config.HandshakeContinuationTimeout;
+            // TODO pass cancellationToken
             await _frameHandler.SendProtocolHeaderAsync()
                 .ConfigureAwait(false);
+            // TODO there is no timeout here, hmm
             ConnectionStartDetails connectionStart = await connectionStartCell.Task
                 .ConfigureAwait(false);
 
diff --git a/projects/RabbitMQ.Client/client/impl/Connection.cs b/projects/RabbitMQ.Client/client/impl/Connection.cs
@@ -228,11 +228,13 @@ await _frameHandler.ConnectAsync(cancellationToken)
                     .ConfigureAwait(false);
 
                 // Note: this must happen *after* the frame handler is started
-                _mainLoopTask = Task.Run(MainLoop);
+                _mainLoopTask = Task.Run(MainLoop, cancellationToken);
 
+                // TODO pass cancellationToken
                 await StartAndTuneAsync()
                     .ConfigureAwait(false);
 
+                // TODO maybe pass cancellationToken
                 await _channel0.ConnectionOpenAsync(_config.VirtualHost)
                     .ConfigureAwait(false);
 
diff --git a/projects/RabbitMQ.Client/client/impl/SocketFrameHandler.cs b/projects/RabbitMQ.Client/client/impl/SocketFrameHandler.cs
@@ -283,6 +283,7 @@ public bool TryReadFrame(out InboundFrame frame)
             return InboundFrame.TryReadFrameFromPipe(_pipeReader, _amqpTcpEndpoint.MaxMessageSize, out frame);
         }
 
+        // TODO cancellationToken
         public async Task SendProtocolHeaderAsync()
         {
             await _pipeWriter.WriteAsync(Amqp091ProtocolHeader)

Original file line number	Diff line number	Diff line change
`@@ -226,7 +226,6 @@ await RecoverChannelsAndItsConsumersAsync(recordedEntitiesSemaphoreHeld: true)`
`226`	`226`	`return false;`
`227`	`227`	`}`
`228`	`228`
`229`		`- // TODO cancellation token`
`230`	`229`	`private async ValueTask<bool> TryRecoverConnectionDelegateAsync(CancellationToken cancellationToken)`
`231`	`230`	`{`
`232`	`231`	`try`
Original file line number	Diff line number	Diff line change
`@@ -69,14 +69,17 @@ internal void HandleConnectionUnblocked()`
`69`	`69`	`}`
`70`	`70`	`}`
`71`	`71`
	`72`	`+ // TODO cancellationToken`
`72`	`73`	`private async ValueTask StartAndTuneAsync()`
`73`	`74`	`{`
`74`	`75`	`var connectionStartCell = new TaskCompletionSource<ConnectionStartDetails>(TaskCreationOptions.RunContinuationsAsynchronously);`
`75`	`76`	`_channel0.m_connectionStartCell = connectionStartCell;`
`76`	`77`	`_channel0.HandshakeContinuationTimeout = _config.HandshakeContinuationTimeout;`
`77`	`78`	`_frameHandler.ReadTimeout = _config.HandshakeContinuationTimeout;`
	`79`	`+ // TODO pass cancellationToken`
`78`	`80`	`await _frameHandler.SendProtocolHeaderAsync()`
`79`	`81`	`.ConfigureAwait(false);`
	`82`	`+ // TODO there is no timeout here, hmm`
`80`	`83`	`ConnectionStartDetails connectionStart = await connectionStartCell.Task`
`81`	`84`	`.ConfigureAwait(false);`
`82`	`85`
Original file line number	Diff line number	Diff line change
`@@ -283,6 +283,7 @@ public bool TryReadFrame(out InboundFrame frame)`
`283`	`283`	`return InboundFrame.TryReadFrameFromPipe(_pipeReader, _amqpTcpEndpoint.MaxMessageSize, out frame);`
`284`	`284`	`}`
`285`	`285`
	`286`	`+ // TODO cancellationToken`
`286`	`287`	`public async Task SendProtocolHeaderAsync()`
`287`	`288`	`{`
`288`	`289`	`await _pipeWriter.WriteAsync(Amqp091ProtocolHeader)`