* Simplify method, add comments

Author: lukebakken

projects/RabbitMQ.Client/client/framing/Channel.cs

@@ -63,10 +63,24 @@ public override Task BasicRejectAsync(ulong deliveryTag, bool requeue)
             return ModelSendAsync(method, CancellationToken.None).AsTask();
         }
 
+        /// <summary>
+        /// Returning <c>true</c> from this method means that the command was server-originated,
+        /// and handled already.
+        /// Returning <c>false</c> (the default) means that the incoming command is the response to
+        /// a client-initiated RPC call, and must be handled.
+        /// </summary>
+        /// <param name="cmd">The incoming command from the AMQP server</param>
+        /// <param name="cancellationToken">The cancellation token</param>
+        /// <returns></returns>
         protected override Task<bool> DispatchCommandAsync(IncomingCommand cmd, CancellationToken cancellationToken)
         {
             switch (cmd.CommandId)
             {
+                case ProtocolCommandId.BasicCancel:
+                    {
+                        HandleBasicCancel(in cmd);
+                        return Task.FromResult(true);
+                    }
                 case ProtocolCommandId.BasicDeliver:
                     {
                         HandleBasicDeliver(in cmd);
@@ -77,27 +91,6 @@ protected override Task<bool> DispatchCommandAsync(IncomingCommand cmd, Cancella
                         HandleBasicAck(in cmd);
                         return Task.FromResult(true);
                     }
-                case ProtocolCommandId.BasicCancel:
-                    {
-                        HandleBasicCancel(in cmd);
-                        return Task.FromResult(true);
-                    }
-                case ProtocolCommandId.BasicCancelOk:
-                    {
-                        return Task.FromResult(false);
-                    }
-                case ProtocolCommandId.BasicConsumeOk:
-                    {
-                        return Task.FromResult(false);
-                    }
-                case ProtocolCommandId.BasicGetEmpty:
-                    {
-                        return Task.FromResult(false);
-                    }
-                case ProtocolCommandId.BasicGetOk:
-                    {
-                        return Task.FromResult(false);
-                    }
                 case ProtocolCommandId.BasicNack:
                     {
                         HandleBasicNack(in cmd);
@@ -110,6 +103,7 @@ protected override Task<bool> DispatchCommandAsync(IncomingCommand cmd, Cancella
                     }
                 case ProtocolCommandId.ChannelClose:
                     {
+                        // Note: always returns true
                         return HandleChannelCloseAsync(cmd, cancellationToken);
                     }
                 case ProtocolCommandId.ChannelCloseOk:
@@ -119,6 +113,7 @@ protected override Task<bool> DispatchCommandAsync(IncomingCommand cmd, Cancella
                     }
                 case ProtocolCommandId.ChannelFlow:
                     {
+                        // Note: always returns true
                         return HandleChannelFlowAsync(cmd, cancellationToken);
                     }
                 case ProtocolCommandId.ConnectionBlocked:
@@ -128,6 +123,7 @@ protected override Task<bool> DispatchCommandAsync(IncomingCommand cmd, Cancella
                     }
                 case ProtocolCommandId.ConnectionClose:
                     {
+                        // Note: always returns true
                         return HandleConnectionCloseAsync(cmd, cancellationToken);
                     }
                 case ProtocolCommandId.ConnectionSecure:
@@ -137,6 +133,7 @@ protected override Task<bool> DispatchCommandAsync(IncomingCommand cmd, Cancella
                     }
                 case ProtocolCommandId.ConnectionStart:
                     {
+                        // Note: always returns true
                         return HandleConnectionStartAsync(cmd, cancellationToken);
                     }
                 case ProtocolCommandId.ConnectionTune:
@@ -149,11 +146,10 @@ protected override Task<bool> DispatchCommandAsync(IncomingCommand cmd, Cancella
                         HandleConnectionUnblocked(in cmd);
                         return Task.FromResult(true);
                     }
-                case ProtocolCommandId.QueueDeclareOk:
+                default:
                     {
                         return Task.FromResult(false);
                     }
-                default: return Task.FromResult(false);
             }
         }
     }