Skip to content

Optimizations for readers #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Sep 22, 2025
Merged

Optimizations for readers #192

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
57c7b5b
Update send_file callback to save a system call
acogoluegnes Jul 4, 2025
78332e6
Read ahead chunk body if previous chunk was small enough
acogoluegnes Jul 8, 2025
01b50a8
Refactoring
kjnilsson Jul 29, 2025
8e7bd7b
Use actual filter size in read ahead
acogoluegnes Aug 1, 2025
25efbfd
refactoring
kjnilsson Aug 26, 2025
3d688da
Test read ahead
acogoluegnes Sep 2, 2025
9e48879
Add function to generate a log
acogoluegnes Sep 9, 2025
fef8b25
revised readahead approach for chunk iterators
kjnilsson Sep 11, 2025
5a0d21a
Make read-ahead an opt-out
acogoluegnes Sep 12, 2025
3868e51
Allow read ahed buffer to be passed from iterator to log reader.
kjnilsson Sep 12, 2025
1b71063
Add read_ahead to reader options
acogoluegnes Sep 12, 2025
01427d8
Only enable read ahead if prior chunk can be full covered
kjnilsson Sep 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/osiris.erl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,8 @@
-type entry() :: binary() | batch().
-type reader_options() :: #{transport => tcp | ssl,
chunk_selector => all | user_data,
filter_spec => osiris_bloom:filter_spec()
filter_spec => osiris_bloom:filter_spec(),
read_ahead => boolean()
}.

-export_type([name/0,
Expand Down
5 changes: 5 additions & 0 deletions src/osiris_bloom.erl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@

init_matcher/1,
is_match/2,
filter_size/1,

bit_set/2,
make_hash/2
Expand Down Expand Up @@ -90,6 +91,10 @@ is_match(_Filter, undefined) ->
%% if no reader filter is set
true.

-spec filter_size(mstate()) -> non_neg_integer().
filter_size(#matcher{current_bit_size = BitSz}) ->
BitSz div 8.


-spec init(filter_size()) -> state().
init(SizeB) when is_integer(SizeB) andalso
Expand Down
Loading