Skip to content

Commit 7b476b4

Browse files
committed
osiris_log_manifest: Add close_manifest/1
1 parent 4174aff commit 7b476b4

File tree

2 files changed

+9
-1
lines changed

2 files changed

+9
-1
lines changed

src/osiris_log.erl

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,7 @@
5858
%% osiris_log_manifest callbacks (default implementations)
5959
-export([init_manifest/2,
6060
finalize_manifest/1,
61+
close_manifest/1,
6162
handle_event/2,
6263
fix_corrupted_files/1,
6364
truncate_to/3,
@@ -1805,10 +1806,12 @@ needs_handling(_, _, _) ->
18051806
close(#?MODULE{cfg = #cfg{counter_id = CntId,
18061807
readers_counter_fun = Fun},
18071808
fd = SegFd,
1808-
index_fd = IdxFd}) ->
1809+
index_fd = IdxFd,
1810+
manifest = {ManifestMod, Manifest}}) ->
18091811
close_fd(IdxFd),
18101812
close_fd(SegFd),
18111813
Fun(-1),
1814+
ok = ManifestMod:close_manifest(Manifest),
18121815
case CntId of
18131816
undefined ->
18141817
ok;
@@ -3333,6 +3336,9 @@ finalize_manifest(#manifest{} = Manifest0) ->
33333336
%% The index files list might be long. Clear it after init to save memory.
33343337
Manifest0#manifest{index_files = undefined}.
33353338

3339+
close_manifest(#manifest{}) ->
3340+
ok.
3341+
33363342
handle_event(_Event, Manifest) ->
33373343
Manifest.
33383344

src/osiris_log_manifest.erl

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,8 @@
2121
%% init.
2222
-callback finalize_manifest(state()) -> state().
2323

24+
-callback close_manifest(state()) -> ok.
25+
2426
-callback handle_event(event(), state()) -> state().
2527

2628
-callback fix_corrupted_files(state()) -> state().

0 commit comments

Comments
 (0)