Skip to content

Commit 17fc5d7

Browse files
committed
Fix panic in tests
Reported in https://github.com/rabbitmq/amqp091-go/actions/runs/5333022714/jobs/9662961511 ``` panic: runtime error: invalid memory address or nil pointer dereference panic: runtime error: invalid memory address or nil pointer dereference [signal 0xc0000005 code=0x0 addr=0x0 pc=0x7e012c] goroutine 3810 [running]: github.com/rabbitmq/amqp091-go.(*Connection).IsClosed(...) D:/a/amqp091-go/amqp091-go/connection.go:455 github.com/rabbitmq/amqp091-go.(*Connection).Close(0x0) D:/a/amqp091-go/amqp091-go/connection.go:388 +0x4c panic({0x86a960, 0xb32080}) C:/hostedtoolcache/windows/go/1.20.5/x64/src/runtime/panic.go:890 +0x263 github.com/rabbitmq/amqp091-go.(*Connection).ConnectionState(...) D:/a/amqp091-go/amqp091-go/connection.go:317 github.com/rabbitmq/amqp091-go.TestTLSHandshake.func2() D:/a/amqp091-go/amqp091-go/tls_test.go:111 +0x27b created by github.com/rabbitmq/amqp091-go.TestTLSHandshake D:/a/amqp091-go/amqp091-go/tls_test.go:104 +0x3e6 exit status 2 ``` If DialTLS returns an error, c will be nil, causing a panic later on in c.ConnectionState() Signed-off-by: Aitor Pérez Cedres <acedres@vmware.com>
1 parent 4f02d9d commit 17fc5d7

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

tls_test.go

+1
Original file line numberDiff line numberDiff line change
@@ -105,6 +105,7 @@ func TestTLSHandshake(t *testing.T) {
105105
c, err := DialTLS(srv.URL, tlsClientConfig(t))
106106
if err != nil {
107107
errs <- fmt.Errorf("expected to open a TLS connection, got err: %v", err)
108+
return
108109
}
109110
defer c.Close()
110111

0 commit comments

Comments
 (0)