Remove newtonsoft.json dependency (AutomatedLab#1775)

Author: nyanhp

.build/02-build.ps1

@@ -173,7 +173,7 @@ foreach ($source in [IO.DirectoryInfo[]]@('./publish/AutomatedLab', './publish/A
     Copy-Item -Path $sourcePath -Destination $modulePath -Force -Recurse
 }
 
-Save-Module -Name AutomatedLab.Common, newtonsoft.json, Ships, PSFramework, xPSDesiredStateConfiguration, xDscDiagnostics, xWebAdministration -Path ./deb/automatedlab/usr/local/share/powershell/Modules
+Save-Module -Name AutomatedLab.Common, Ships, PSFramework, xPSDesiredStateConfiguration, xDscDiagnostics, xWebAdministration -Path ./deb/automatedlab/usr/local/share/powershell/Modules
 
 # Pre-configure LabSources for the user
 $confPath = "./deb/automatedlab/usr/local/share/powershell/Modules/AutomatedLab/$($env:APPVEYOR_BUILD_VERSION)/AutomatedLab.init.ps1"

.build/04-publish.ps1

@@ -22,7 +22,7 @@ if (-not $IsLinux)
     {
         Register-PSRepository -Name loc -SourceLocation $nugetpath -PublishLocation $nugetpath
         Publish-Module -Path (Join-Path -Path $modPath -ChildPath PSFileTransfer) -Repository loc
-        foreach ($req in @('newtonsoft.json', 'Pester', 'Ships', 'powershell-yaml', 'PSFramework', 'AutomatedLab.Common'))
+        foreach ($req in @('Pester', 'Ships', 'powershell-yaml', 'PSFramework', 'AutomatedLab.Common'))
         {
             Publish-Module -Name $req -Repository loc -WarningAction SilentlyContinue
         }
@@ -35,7 +35,6 @@ if (-not $IsLinux)
     }
 
     $surplus = @(
-        (Join-Path -Path $nugetpath -ChildPath *newtonsoft.json*)
         (Join-Path -Path $nugetpath -ChildPath *AutomatedLab.Common*)
         (Join-Path -Path $nugetpath -ChildPath *Pester*)
         (Join-Path -Path $nugetpath -ChildPath *Ships*)

AutomatedLabWorker/functions/AzureWorkerVirtualMachines/New-LabAzureResourceGroupDeployment.ps1

@@ -861,7 +861,7 @@
     }
 
     $templatePath = Join-Path -Path (Get-LabConfigurationItem -Name LabAppDataRoot) -ChildPath "Labs/$($Lab.Name)/armtemplate.json"
-    $template | ConvertTo-JsonNewtonsoft | Set-Content -Path $templatePath
+    ConvertTo-Json -InputObject $template -Depth 42 | Set-Content -Path $templatePath
 
     Write-ScreenInfo -Message "Deploying new resource group with template $templatePath"
     # Without wait - unable to catch exception

CHANGELOG.md

@@ -6,6 +6,9 @@
 
 ### Bugs
 
+- Removed dependency to NewtonSoft.Json
+    - The module frequently hinders import on Linux, and apparently on Windows now as well (<https://github.com/AutomatedLab/AutomatedLab.Common/issues/132>)
+    - The module has not been updated since 2019
 - Fixed issue with case-sensitive Linux OS name matching (#1766)
 - Added filtering to Install-LabSshKnownHost in an attempt to speed up the function
 

Help/Wiki/Basic/install.md

@@ -10,8 +10,7 @@ There are two options installing AutomatedLab:
 ```powershell
 Install-PackageProvider Nuget -Force
 # SkipPublisherCheck: AutomatedLabTest requires Pester v5. On system where Pester v3 is still the only versions, you will get an error if the parameter is not present
-# AllowClobber: On some occasions, other modules seem to have published ConvertTo-Json/ConvertFrom-Json, which is overwritten by Newtonsoft.Json
-Install-Module AutomatedLab -SkipPublisherCheck -AllowClobber
+Install-Module AutomatedLab -SkipPublisherCheck
 
 #region Non-interactive host
 # Pre-configure telemetry

Installer/.Build/PostBuild.ps1

@@ -4,7 +4,7 @@
 
     [Parameter()]
     [string[]]
-    $ExternalDependency = @('PSFramework', 'newtonsoft.json', 'SHiPS', 'xPSDesiredStateConfiguration', 'xDscDiagnostics', 'xWebAdministration'),
+    $ExternalDependency = @('PSFramework', 'SHiPS', 'xPSDesiredStateConfiguration', 'xDscDiagnostics', 'xWebAdministration'),
 
     [Parameter()]
     [string[]]

Installer/.Build/PreBuild.ps1

@@ -4,7 +4,7 @@
 
     [Parameter()]
     [string[]]
-    $ExternalDependency = @('Pester', 'PSFramework', 'newtonsoft.json', 'SHiPS', 'AutomatedLab.Common', 'xPSDesiredStateConfiguration', 'xDscDiagnostics', 'xWebAdministration', 'powershell-yaml'),
+    $ExternalDependency = @('Pester', 'PSFramework', 'SHiPS', 'AutomatedLab.Common', 'xPSDesiredStateConfiguration', 'xDscDiagnostics', 'xWebAdministration', 'powershell-yaml'),
 
     [Parameter()]
     [string[]]