Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.INCLUDE statement - manually editing Filename or Browse doesn't work - altermod usage #948

Closed
tomhajjar opened this issue Sep 15, 2024 · 8 comments · Fixed by #955
Closed
Labels
Milestone

Comments

@tomhajjar
Copy link

tomhajjar commented Sep 15, 2024

Having two issues:

  1. .INCLUDE statement manually editing Filename or using Browse doesn't work anymore. I tried manually editing the Spice filename and file info goes blank. I then tried using Browse and again file info goes blank. You can do all the steps, click "Apply" and everything looks good but when you click "OK" all fields go blank. In fact make no changes and click "OK" and all the fields go blank. I have to use a text editor to make the changes or repair the file.

For simplicity, I decided to shorten the filename "hicumL2V2p40_model_card.lib" -> "hicumL2V2p40.lib" and found the issue.

  1. I wanted to reproduce the data in the ngspice netlist "hic2_ib_ic_thermal.sp" and can't figure out how to get the line
    "altermod @hicumL2V2p40[flsh]=1" to work in Qucs. The last pic is the ngspice plots for hic2_ib_ic_thermal.sp.

2024-09-15_184709
2024-09-15_192034
2024-09-15_203855

HICUM2_prj.zip

@tomhajjar tomhajjar changed the title .INCLUDE statement Filename Edit/Browse doesn't work - altermod usage .INCLUDE statement - manually editing Filename or Browse doesn't work - altermod usage Sep 15, 2024
@ra3xdh
Copy link
Owner

ra3xdh commented Sep 16, 2024

INCLUDE statement manually editing Filename or using Browse doesn't work anymore.

I confirm this bug. There is no workaround. This bug is critical. I will prepare v24.3.2 release containing the fix as soon as possible.

@ra3xdh ra3xdh added the bug label Sep 16, 2024
@ra3xdh ra3xdh added this to the 24.3.2 milestone Sep 16, 2024
@tomhajjar
Copy link
Author

I will use the text editor work-around.

Can you show how to get "altermod @hicumL2V2p40[flsh]=1" in the ngspice netlist "hic2_ib_ic_thermal.sp" to work in Qucs?

@ra3xdh
Copy link
Owner

ra3xdh commented Sep 17, 2024

Can you show how to get "altermod @hicumL2V2p40[flsh]=1" in the ngspice netlist "hic2_ib_ic_thermal.sp" to work in Qucs?

There is no way except composing a custom Nutmeg script. I have deprecated the explicit SweepModel property of the Parameter sweep. See #839 But I didn't take into account that the model may be defined outside schematic in the library file using .include. There is not way to substitute the variable for model defined in the external file.

@tomhajjar
Copy link
Author

I took the easy way out and made a 2nd Spice model file with "thermal" enabled.

2024-09-18_205522

HICUM2_prj.zip

@ra3xdh
Copy link
Owner

ra3xdh commented Sep 19, 2024

The both issues are fixed on this branch https://github.com/ra3xdh/qucs_s/tree/release/24.3.2 I will try to prepare the 24.3.2 update in the next few days. I have added model sweep pattern recognition.

image

@tomhajjar
Copy link
Author

tomhajjar commented Sep 19, 2024

Updated files: 9/23/24

Will it work for both cases like xyce?

2024-09-23_184119
2024-09-23_184049
2024-09-23_184020

BJT_Beta_sweep.zip

@ra3xdh
Copy link
Owner

ra3xdh commented Sep 19, 2024

There is no difference where defined the model. Both cases should work.

This was referenced Sep 20, 2024
@ra3xdh ra3xdh linked a pull request Sep 23, 2024 that will close this issue
@ra3xdh
Copy link
Owner

ra3xdh commented Sep 23, 2024

Fixed by #955

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants