refactor: fix code smells from sonarqube

Author: jbl428

lib/builders/url.builder.ts

@@ -37,7 +37,7 @@ export class UrlBuilder {
   }
 
   private isStartWithProtocol(): boolean {
-    return this.host.match(/^https?:\/\//) != null;
+    return /^https?:\/\//.exec(this.host) != null;
   }
 
   private replaceSlash(url: string): string {

lib/decorators/path-variable.decorator.spec.ts

@@ -7,8 +7,9 @@ describe('PathVariable', () => {
   test('should not create path variable metadata when not on method', () => {
     // given
     class TestService {
+      foo: string;
       constructor(@PathVariable('foo') foo: string) {
-        return foo;
+        this.foo = foo;
       }
     }
 

lib/decorators/request-body.decorator.spec.ts

@@ -8,8 +8,9 @@ describe('RequestBody', () => {
   test('should not create request body metadata when not on method', () => {
     // given
     class TestService {
+      foo: string;
       constructor(@RequestBody() foo: string) {
-        return foo;
+        this.foo = foo;
       }
     }
 

lib/decorators/request-form.decorator.spec.ts

@@ -8,8 +8,9 @@ describe('RequestForm', () => {
   test('should not create request form metadata when not on method', () => {
     // given
     class TestService {
+      foo: string;
       constructor(@RequestForm() foo: string) {
-        return foo;
+        this.foo = foo;
       }
     }
 

lib/decorators/request-header.decorator.spec.ts

@@ -8,8 +8,9 @@ describe('RequestHeader', () => {
   test('should not create request header metadata when not on method', () => {
     // given
     class TestService {
+      foo: string;
       constructor(@RequestHeader() foo: string) {
-        return foo;
+        this.foo = foo;
       }
     }
 

lib/decorators/request-param.decorator.spec.ts

@@ -7,8 +7,9 @@ describe('RequestParam', () => {
   test('should not create request param metadata when not on method', () => {
     // given
     class TestService {
+      foo: string;
       constructor(@RequestParam() foo: string) {
-        return foo;
+        this.foo = foo;
       }
     }
 

lib/decorators/response-body.decorator.spec.ts

@@ -6,7 +6,9 @@ import { type ResponseBodyBuilder } from '../builders/response-body.builder';
 describe('ResponseBody', () => {
   test('should set response body metadata', () => {
     // given
-    class TestResponse {}
+    class TestResponse {
+      constructor(readonly foo: string) {}
+    }
     class TestService {
       @ResponseBody(TestResponse, { version: 1 })
       async request(): Promise<string> {

lib/plugin/utils/plugin-utils.ts

@@ -27,7 +27,9 @@ export function replaceImportPath(
     return typeReference.replace('import', 'require');
   } catch (_error) {
     let relativePath = posix.relative(posix.dirname(fileName), importPath);
-    relativePath = relativePath[0] !== '.' ? './' + relativePath : relativePath;
+    relativePath = !relativePath.startsWith('.')
+      ? './' + relativePath
+      : relativePath;
 
     const nodeModulesText = 'node_modules';
     const nodeModulePos = relativePath.indexOf(nodeModulesText);