Skip to content
This repository was archived by the owner on Jan 15, 2024. It is now read-only.

Conversation

@javierluraschi
Copy link
Contributor

MinGW x86/x64 now working: apache/arrow#3693

This PR attempts to build using that particular checkpoint.

@jeroen
Copy link
Contributor

jeroen commented Mar 6, 2019

Thanks, looks promising. This build does not have parquet support yet I think (which is assumed in the latest R bindings)?

pkgname="${MINGW_PACKAGE_PREFIX}-${_realname}"
pkgver=0.12.0
pkgver=0.12.9000
srcver=0.13
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

srcver=0.13.0 should work

@javierluraschi
Copy link
Contributor Author

BTW. Regarding parquet, we can add #ifdef and disable it, I used something like:

--- a/r/src/parquet.cpp
+++ b/r/src/parquet.cpp
@@ -17,12 +17,16 @@

 #include <arrow/api.h>
 #include <arrow/io/api.h>
+
+#ifdef ARROW_R_PARQUET_ON
 #include <parquet/arrow/reader.h>
 #include <parquet/arrow/writer.h>
 #include <parquet/exception.h>
+#endif

 // [[Rcpp::export]]
 std::shared_ptr<arrow::Table> read_parquet_file(std::string filename) {
+#ifdef ARROW_R_PARQUET_ON
   std::shared_ptr<arrow::io::ReadableFile> infile;
   PARQUET_THROW_NOT_OK(
       arrow::io::ReadableFile::Open(filename, arrow::default_memory_pool(), &infile));
@@ -34,4 +38,8 @@ std::shared_ptr<arrow::Table> read_parquet_file(std::string filename) {
   PARQUET_THROW_NOT_OK(reader->ReadTable(&table));

   return table;
+#else
+  std::shared_ptr<arrow::Table> table;
+  return table;
+#endif
 }

I can push a slightly better change in arrow when needed.

@jeroen
Copy link
Contributor

jeroen commented Mar 11, 2019

The -Wshift-count-overflow compiler warnings are almost certainly bugs.

@jeroen jeroen merged commit 2d9d4e4 into r-windows:master Mar 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants