Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the unary union of the empty multipolygon #208

Merged
merged 6 commits into from
Dec 27, 2022
Merged

Conversation

paleolimbot
Copy link
Collaborator

As identified in r-spatial/sf#2053. A minimal reprex is s2::s2_union("MULTIPOLYGON EMPTY").

@codecov-commenter
Copy link

Codecov Report

Merging #208 (4188ca5) into main (8e0853b) will decrease coverage by 0.13%.
The diff coverage is 42.85%.

@@            Coverage Diff             @@
##             main     #208      +/-   ##
==========================================
- Coverage   94.16%   94.02%   -0.14%     
==========================================
  Files          46       46              
  Lines        3495     3517      +22     
==========================================
+ Hits         3291     3307      +16     
- Misses        204      210       +6     
Impacted Files Coverage Δ
src/s2geography/build.cc 90.50% <33.33%> (-1.73%) ⬇️
src/s2geography/geography.h 100.00% <100.00%> (ø)
src/s2geography/accessors.cc 90.00% <0.00%> (-1.25%) ⬇️
src/s2geography/accessors-geog.cc 88.34% <0.00%> (-0.87%) ⬇️
src/s2geography/constructor.h 91.87% <0.00%> (-0.80%) ⬇️
src/s2-cell-union.cpp 99.47% <0.00%> (-0.01%) ⬇️
src/s2geography/build.h 100.00% <0.00%> (ø)
src/s2-transformers.cpp 97.29% <0.00%> (+0.01%) ⬆️
src/s2-constructors-formatters.cpp 95.76% <0.00%> (+0.02%) ⬆️
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@paleolimbot paleolimbot merged commit dbb8cda into main Dec 27, 2022
@paleolimbot paleolimbot deleted the empty-geogs branch December 27, 2022 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants