Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make sure aggregate centroids normalize points #121

Merged
merged 1 commit into from
Jun 5, 2021
Merged

Conversation

paleolimbot
Copy link
Collaborator

Makes sure that .Normalize() is called on points before creating the PointGeography (#119). This was already the case for non-aggregate centroids, which were created correctly.

@codecov-commenter
Copy link

Codecov Report

Merging #121 (8401275) into master (e39716e) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #121   +/-   ##
=======================================
  Coverage   94.04%   94.04%           
=======================================
  Files          40       40           
  Lines        2987     2987           
=======================================
  Hits         2809     2809           
  Misses        178      178           
Impacted Files Coverage Δ
src/s2-transformers.cpp 96.70% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e39716e...8401275. Read the comment docs.

@paleolimbot paleolimbot merged commit 8491cd3 into master Jun 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants