new CRAN message

[edzer]

Dear maintainer,

Please see the problems shown on
https://cran.r-project.org/web/checks/check_results_s2.html.

Please correct before 2022-11-22 to safely retain your package on CRAN.

The CRAN Team

[paleolimbot]

Hmm...looks like there's two problems:

../src/absl/container/internal/raw_hash_set.h: In function ‘__m128i absl::lts_20210324::container_internal::_mm_cmpgt_epi8_fixed(__m128i, __m128i)’:
../src/absl/container/internal/raw_hash_set.h:329:40: warning: overflow in conversion from ‘int’ to ‘char’ changes value from ‘128’ to ‘'\37777777600'’ [-Woverflow]
  329 |     const __m128i mask = _mm_set1_epi8(0x80);

and

Found the following significant warnings:
  s2/util/math/exactfloat/exactfloat.cc:412:5: warning: 'sprintf' is deprecated: This function is provided for compatibility reasons only.  Due to security concerns inherent in the design of sprintf(3), it is highly recommended that you use snprintf(3) instead. [-Wdeprecated-declarations]
  s2/util/math/exactfloat/exactfloat.cc:515:3: warning: 'sprintf' is deprecated: This function is provided for compatibility reasons only.  Due to security concerns inherent in the design of sprintf(3), it is highly recommended that you use snprintf(3) instead. [-Wdeprecated-declarations]
See ‘/Users/ripley/R/packages/tests-devel/s2.Rcheck/00install.out’ for details.

[paleolimbot]

I think I can do this in a patch, although the real solution is to update S2 and abseil to the latest releases.

[edzer]

Fantastic! I'm OK with either way - we can leave the update for a later stage?

[edzer]

Are you ok to release to CRAN, as is?

[paleolimbot]

Let me go through a release checklist this evening or tomorrow evening to make sure, but in theory yes!

[edzer]

With wk 0.7.1 I still see

Running the tests in ‘tests/testthat.R’ failed.
Last 13 lines of output:
  Error in `as.data.frame.wk_vctr(new_s2_cell(NA_real_))`: cannot coerce object of tyoe 's2_cell' to data.frame
  Backtrace:
      ▆
   1. ├─testthat::expect_error(...) at test-s2-cell.R:232:2
   2. │ └─testthat:::expect_condition_matching(...)
   3. │   └─testthat:::quasi_capture(...)
   4. │     ├─testthat (local) .capture(...)
   5. │     │ └─base::withCallingHandlers(...)
   6. │     └─rlang::eval_bare(quo_get_expr(.quo), quo_get_env(.quo))
   7. ├─base::as.data.frame(new_s2_cell(NA_real_))
   8. └─wk:::as.data.frame.wk_vctr(new_s2_cell(NA_real_))

[edzer]

also after

remotes::install_github("paleolimbot/wk")

[paleolimbot]

I can't replicate this with an updated R + updated wk + s2 from main? I have a winbuilder check out now which should confirm that too (since I'm not running r-devel).

[edzer]

new CRAN message:

Dear maintainer,

Please see the problems shown on
[<https://cran.r-project.org/web/checks/check_results_s2.html>](https://cran.r-project.org/web/checks/check_results_s2.html).

Please correct before 2023-01-23 to safely retain your package on CRAN.

Note that this will be the *final* reminder.

The CRAN Team