New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add maximum distance constraint to `s2_closest_edges()` #156

Closed

paleolimbot opened this issue Dec 31, 2021 · 2 comments

Collaborator

paleolimbot commented Dec 31, 2021

As requested by Roger Bivand here: #125 (comment)

Where the option needs to be added: https://github.com/r-spatial/s2/blob/master/src/s2-matrix.cpp#L175

Documentation for the option: https://github.com/r-spatial/s2/blob/main/src/s2/s2closest_edge_query.h#L126-L135

paleolimbot mentioned this issue

Add max_distance argument to s2_closest edges() #162

Merged

Member

rsbivand commented Jan 17, 2022 •

edited

Loading

Thanks, very helpful! Any target release timeframe?

Collaborator Author

paleolimbot commented Jan 17, 2022

I am hoping late February!

paleolimbot closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment