Don't omit trailing non-code lines from knitr files #1403
Conversation
NEWS.md
Outdated
| @@ -5,6 +5,10 @@ | |||
| * `seq_linter()` additionally lints on `1:n()` (from dplyr) | |||
| and `1:.N` (from data.table) (#1396, @IndrajeetPatil). | |||
|
|
|||
| ## Bug fixes | |||
|
|
|||
| * `get_source_expression()` no longer omits trailing non-code lines from knitr files (#1400, @AshesITR). | |||
There was a problem hiding this comment.
get_source_expressions?
There was a problem hiding this comment.
That's the affected public facing function.
There was a problem hiding this comment.
i mean, is it a typo? i know we have an internal get_source_expression
| abc = 123 | ||
| ``` | ||
|
|
||
| ```{r child="some-file.Rmd"} |
There was a problem hiding this comment.
false positive lint here?
There was a problem hiding this comment.
also note the NA -- seems the linter name has not been picked up correctly
There was a problem hiding this comment.
It seems the test code is linted as Rmd for some reason?!
The NA should be investigated in a separate issue. Maybe we stumbled on an actual bug in the extractor code.
There was a problem hiding this comment.
Can't seem to find the issue from a quick search but AFAIK that should be related to the known issue where our logic for classifying Rmd is not the best.
There was a problem hiding this comment.
Filed #1405 for the NA issue
NEWS.md
Outdated
| @@ -5,6 +5,12 @@ | |||
| * `seq_linter()` additionally lints on `1:n()` (from dplyr) | |||
| and `1:.N` (from data.table) (#1396, @IndrajeetPatil). | |||
|
|
|||
| ## Bug fixes | |||
|
|
|||
| * `get_source_expression()` no longer omits trailing non-code lines from knitr files (#1400, @AshesITR). | |||
There was a problem hiding this comment.
still hoping to clarify if it's a typo -- shouldn't this have a trailing s?
There was a problem hiding this comment.
Oh, good catch! Yes, it should.
|
|
||
| # Construct an Rmd file without terminal newline | ||
| tmp3 <- withr::local_tempfile() | ||
| # TODO (@AshesITR): Remove \n escapes when #1406 is fixed |
There was a problem hiding this comment.
nit: btw I think TODO(#1406) is better in general, then you can assign yourself the issue. makes it easier in case you decide to go on hiatus & not care about the issue for a few years :)
fixes #1400