Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

object_usage_linter could me made glue-aware #942

Closed
MichaelChirico opened this issue Mar 14, 2022 · 0 comments · Fixed by #969
Closed

object_usage_linter could me made glue-aware #942

MichaelChirico opened this issue Mar 14, 2022 · 0 comments · Fixed by #969

Comments

@MichaelChirico
Copy link
Collaborator

See discussion here: #924 (comment)

And Jim's recommendation here: MichaelChirico/potools#252 (comment)

We could use this to cover objects which are only used inside glue interpolation.
@MichaelChirico MichaelChirico mentioned this issue Mar 14, 2022
Merged
@AshesITR AshesITR mentioned this issue Mar 21, 2022
Open
AshesITR added a commit that referenced this issue Mar 21, 2022
@AshesITR
fix #942
964d3b9
This was referenced Mar 21, 2022
Merged
Merged
MichaelChirico added a commit that referenced this issue Mar 21, 2022
@AshesITR @MichaelChirico
Make object_usage_linter glue aware (#969)
1e08b13 
* fix #942

* add test for .open and .close

* add test for non-default argument

* [temp] disable tryCatch() to check build system check failures

* Revert "[temp] disable tryCatch() to check build system check failures"

This reverts commit f3f2335.

* document()

* use keep.source = TRUE

* remove nolints, add TODO comment

* comments

Co-authored-by: Michael Chirico <chiricom@google.com>
@AshesITR AshesITR mentioned this issue Jun 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make object_usage_linter glue aware r-lib/lintr
1 participant
@MichaelChirico