Iron out styling inconsistencies (#2194)

Author: IndrajeetPatil

R/indentation_linter.R

@@ -225,7 +225,8 @@ indentation_linter <- function(indent = 2L, hanging_indent_style = c("tidy", "al
 
     indent_levels <- re_matches(
       source_expression$file_lines,
-      rex(start, any_spaces), locations = TRUE
+      rex(start, any_spaces),
+      locations = TRUE
     )[, "end"]
     expected_indent_levels <- integer(length(indent_levels))
     is_hanging <- logical(length(indent_levels))
@@ -351,8 +352,7 @@ build_indentation_style_tidy <- function() {
           @line1 = following-sibling::{paren_tokens_right}/{xp_inner_expr}[position() = 1]/@line1
         ]/following-sibling::{paren_tokens_right}[
           @line1 > {xp_inner_expr}[position() = last() - 1]/@line2
-        ]"
-    ),
+        ]"),
     collapse = " | "
   )
 

R/keyword_quote_linter.R

@@ -39,7 +39,7 @@
 #' )
 #'
 #' lint(
-#'   text = 'my_list$`a b`',
+#'   text = "my_list$`a b`",
 #'   linters = keyword_quote_linter()
 #' )
 #'

R/matrix_apply_linter.R

@@ -30,7 +30,6 @@
 #' @seealso [linters] for a complete list of linters available in lintr.
 #' @export
 matrix_apply_linter <- function() {
-
   # mean() and sum() have very different signatures so we treat them separately.
   # sum() takes values to sum over via ..., has just one extra argument and is not a generic
   # mean() is a generic, takes values to average via a single argument, and can have extra arguments
@@ -73,7 +72,7 @@ matrix_apply_linter <- function() {
 
   # This doesn't handle the case when MARGIN and FUN are named and in a different position
   # but this should be relatively rate
-  var_xpath  <- "expr[position() = 2]"
+  var_xpath <- "expr[position() = 2]"
   margin_xpath <- "expr[position() = 3]"
   fun_xpath <- "expr[position() = 4]"
 
@@ -108,7 +107,6 @@ matrix_apply_linter <- function() {
 }
 
 craft_colsums_rowsums_msg <- function(var, margin, fun, narm_val) {
-
   if (is.na(xml_find_first(margin, "OP-COLON"))) {
     l1 <- xml_text(margin)
     l2 <- NULL

R/pipe_consistency_linter.R

@@ -26,8 +26,8 @@
 #' )
 #'
 #' lint(
-#'  text = "1:3 |> mean() |> as.character()",
-#'  linters = pipe_consistency_linter()
+#'   text = "1:3 |> mean() |> as.character()",
+#'   linters = pipe_consistency_linter()
 #' )
 #' @evalRd rd_tags("pipe_consistency_linter")
 #' @seealso [linters] for a complete list of linters available in lintr.

R/repeat_linter.R

@@ -16,7 +16,6 @@
 #'   linters = repeat_linter()
 #' )
 #'
-#'
 #' @evalRd rd_tags("repeat_linter")
 #' @seealso [linters] for a complete list of linters available in lintr.
 #' @export

R/settings.R

@@ -1,4 +1,3 @@
-
 #' Read lintr settings
 #'
 #' Lintr searches for settings for a given source file in the following order:

R/xp_utils.R

@@ -2,7 +2,9 @@
 
 # like `text() %in% table`, translated to XPath 1.0
 xp_text_in_table <- function(table) {
-  if (length(table) == 0L) return("true")
+  if (length(table) == 0L) {
+    return("true")
+  }
   # xpath doesn't seem to have a standard way of escaping quotes, so attempt
   #   to use "" whenever the string has ' (not a perfect solution). info on
   #   escaping from https://stackoverflow.com/questions/14822153