Remove usage of Rf_findVarInFrame3()
#386
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavisVaughan
commented
Aug 20, 2024
Comment on lines
+3
to
+13
| * The `environment` class no longer uses the non-API function | ||
| `Rf_findVarInFrame3()` (#367). | ||
|
|
||
| * The `exists()` method now uses the new `R_existsVarInFrame()` function. | ||
|
|
||
| * The `SEXP` conversion operator now uses the new `R_getVar()` function. Note | ||
| that this is stricter than `Rf_findVarInFrame3()` in 3 ways. The object | ||
| must exist in the environment (i.e. `R_UnboundValue` is no longer returned), | ||
| the object cannot be `R_MissingArg`, and if the object was a promise, that | ||
| promise is now evaluated. We have backported this new strictness to older | ||
| versions of R as well. |
There was a problem hiding this comment.
Summary of the changes
DavisVaughan
force-pushed
the
feature/remove-findvarinframe3
branch
from
4ba1e9e to
db4d17c
Compare
lionel-
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #367