Fail fast and informatively for nonexistent file #261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jennybc
commented
Feb 4, 2022
| @@ -67,6 +67,9 @@ | |||
| #' @export | |||
| cpp_source <- function(file, code = NULL, env = parent.frame(), clean = TRUE, quiet = TRUE, cxx_std = Sys.getenv("CXX_STD", "CXX11"), dir = tempfile()) { | |||
| stop_unless_installed(c("brio", "callr", "cli", "decor", "desc", "glue", "tibble", "vctrs")) | |||
| if (!missing(file) && !file.exists(file)) { | |||
There was a problem hiding this comment.
!missing(file) seems a bit counter to our "house style". I wonder if the signature should become file = NULL, to indicate file is not required (at least, if code is provided)?
There was a problem hiding this comment.
Should this be informative about the name/path of the file that does not exist ?
There was a problem hiding this comment.
Yeah, I was thinking that too. I've added the non-existent file path to the error now.
There was a problem hiding this comment.
Thanks. Perhaps ultimately this is something fs:: can help with ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If I call
cpp_source()with a nonexistent filepath, interactively I see:I'm not sure why the first snapshot in this PR shows a different (but also non informative) error. But, in any case, it seems better to check early for the existence of
fileand to fail in a more specific way, iffiledoes not exist.