Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename setLabels family functions to meet Tidyverse requirements #35

Open
GegznaV opened this issue Jul 29, 2020 · 0 comments
Open

Rename setLabels family functions to meet Tidyverse requirements #35

GegznaV opened this issue Jul 29, 2020 · 0 comments
Assignees

Comments

@GegznaV
Copy link
Member

GegznaV commented Jul 29, 2020

The family of setLabels functions should be renamed as it doesn't follow Tidyverse conventions, e.g., use only lower-case letters.

setLabels <- function(.data, ...) {

I suggest renaming:

  1. setLabelslabels_set() (I think, that labels_set() and labels_get() should live in the main hyperSpec package as they give core functionality to work with labels).
  2. setLabels_transmutelabels_transmute() (Why is this function needed at all?)
  3. setLabels_selectlabels_select
  4. setLabels_renamelabels_rename

Yet, it is still a bit vague for me, what these functions do and why are they needed. The file with these functions lacks:

  1. description/better explanation, why they are needed;
  2. examples (at least one per function;
  3. unit tests (at least one per function).
@eoduniyi eoduniyi self-assigned this Dec 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants