You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
setLabels → labels_set() (I think, that labels_set() and labels_get() should live in the main hyperSpec package as they give core functionality to work with labels).
setLabels_transmute → labels_transmute() (Why is this function needed at all?)
setLabels_select → labels_select
setLabels_rename → labels_rename
Yet, it is still a bit vague for me, what these functions do and why are they needed. The file with these functions lacks:
description/better explanation, why they are needed;
examples (at least one per function;
unit tests (at least one per function).
The text was updated successfully, but these errors were encountered:
The family of
setLabels
functions should be renamed as it doesn't follow Tidyverse conventions, e.g., use only lower-case letters.hySpc.dplyr/R/setLabels.R
Line 19 in ffbb179
I suggest renaming:
setLabels
→labels_set()
(I think, thatlabels_set()
andlabels_get()
should live in the main hyperSpec package as they give core functionality to work with labels).setLabels_transmute
→labels_transmute()
(Why is this function needed at all?)setLabels_select
→labels_select
setLabels_rename
→labels_rename
Yet, it is still a bit vague for me, what these functions do and why are they needed. The file with these functions lacks:
The text was updated successfully, but these errors were encountered: