Skip to content

Source of functions#18

Merged
SaranjeetKaur merged 6 commits into
r-devel:masterfrom
SaranjeetKaur:source-of-functions
Jun 16, 2021
Merged

Source of functions#18
SaranjeetKaur merged 6 commits into
r-devel:masterfrom
SaranjeetKaur:source-of-functions

Conversation

@SaranjeetKaur

@SaranjeetKaur SaranjeetKaur commented May 12, 2021

Copy link
Copy Markdown
Collaborator

This chapter discusses how you can have an overview of the R codebase.

@SaranjeetKaur SaranjeetKaur marked this pull request as ready for review May 16, 2021 15:40
Comment thread 02-getting_started.Rmd
@@ -1,4 +1,4 @@
# Getting Started
# Getting Started {#GetStart}

@MichaelChirico MichaelChirico May 17, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer a better anchor name here... IINM these anchors are not just for referring internally in the page -- it can show up eventually in a URL as URL/getting-started#GetStart; something more readable would be better. I may be mistaken but I think this may generate an automatic anchor like #getting-started? If not that would anyway be a good choice.

Comment thread 02-getting_started.Rmd
## Installing R
## Installing R {#installR}

1. The binary builds of R for Windows can be downloaded and installed from [here](https://cran.r-project.org/bin/windows/base/). Along with the link to the latest stable release, this page also contains links to the binary builds of r-patched and r-devel.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may be worth adding a quick note what exactly is meant by a "binary build" -- it's something I had no idea on myself for a long time and have sort of figured out gradually.

Comment thread 02-getting_started.Rmd
Comment thread 02-getting_started.Rmd
Comment thread 02-getting_started.Rmd

* To download the R sources on Windows, you can use `tar` from the RStudio terminal.

* If you want to checkout the sources from svn, it is probably best to install an SVN client. Either TortoiseSVN (https://tortoisesvn.net/, command line tool, and Windows Explorer integration) or SlikSVN (https://sliksvn.com/download/, just the command line tool) is recommended. They have simple Windows installers and you can use svn straight-away from Windows cmd or RStudio terminal.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there any concern that TortoiseSVN is GPL (https://en.wikipedia.org/wiki/TortoiseSVN) while SlikSVN appears "freemium"?

Comment thread finding_the_source.Rmd
Comment thread finding_the_source.Rmd
Comment thread finding_the_source.Rmd
* Search in the R sources using grep: The [Getting Started](#GetStart) chapter discusses how to download the R sources directly or from the svn repository. Now if the sources are in `~/R-devel`, you can search as follows:

```
grep -R "body <- function" ~/R-devel/src

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I usually prefer grep -Fnr and --include=*.R

Comment thread finding_the_source.Rmd
Comment thread finding_the_source.Rmd
similarly for grep

```
grep -R --include=*.c "compcases" ~/R-devel/src/library/

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src/library won't match src/main, where all of the base C code is

SaranjeetKaur added a commit that referenced this pull request May 25, 2021
rebase where-to-get-help branch with forwards/rdevguide main branch
@SaranjeetKaur SaranjeetKaur mentioned this pull request Jun 16, 2021
@SaranjeetKaur SaranjeetKaur merged commit e891f4d into r-devel:master Jun 16, 2021
@willingc

Copy link
Copy Markdown
Contributor

Great to see these PRs merging and moving forward.

Nice work being done here by @SaranjeetKaur and all the reviewers 💐

cc/ @jennybc @hadley

@SaranjeetKaur

Copy link
Copy Markdown
Collaborator Author

Many thanks @willingc !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants