Skip to content

Disable SNI checks for HTTPS #1215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 8, 2023
Merged

Disable SNI checks for HTTPS #1215

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
55a16dc
Disable SNI checks for HTTPS
tresf Nov 8, 2023
e3e45e4
Add documentation
tresf Nov 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/qz/ws/PrintSocketServer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,14 @@ private static Server findAvailableSecurePort(CertificateManager certManager) {
try {
// Bind the secure socket on the proper port number (i.e. 8181), add it as an additional connector
SslConnectionFactory sslConnection = new SslConnectionFactory(certManager.configureSslContextFactory(), HttpVersion.HTTP_1_1.asString());
HttpConnectionFactory httpConnection = new HttpConnectionFactory(new HttpConfiguration());

// Disable SNI checks for easier print-server testing (replicates Jetty 9.x behavior)
HttpConfiguration httpsConfig = new HttpConfiguration();
SecureRequestCustomizer customizer = new SecureRequestCustomizer();
customizer.setSniHostCheck(false);
httpsConfig.addCustomizer(customizer);

HttpConnectionFactory httpConnection = new HttpConnectionFactory(httpsConfig);

ServerConnector secureConnector = new ServerConnector(server, sslConnection, httpConnection);
secureConnector.setHost(certManager.getProperties().getProperty("wss.host"));
Expand Down