Add test for sticker pack message extension

jbruechert · jbruechert · commit 3e99aba5a3c9 · 2022-10-02T21:32:32.000+02:00
diff --git a/src/base/QXmppMessage.cpp b/src/base/QXmppMessage.cpp
@@ -1843,6 +1843,7 @@ void QXmppMessage::serializeExtensions(QXmlStreamWriter *writer, QXmpp::SceMode
             writer->writeStartElement("sticker");
             writer->writeDefaultNamespace(ns_stickers);
             writer->writeAttribute("pack", *d->stickerPackId);
+            writer->writeEndElement();
         }
     }
 }
diff --git a/tests/qxmppmessage/tst_qxmppmessage.cpp b/tests/qxmppmessage/tst_qxmppmessage.cpp
@@ -56,6 +56,7 @@ private slots:
     void testE2eeFallbackBody();
     void testFileSharing();
     void testEncryptedFileSource();
+    void testStickers();
 };
 
 void tst_QXmppMessage::testBasic_data()
@@ -1259,5 +1260,31 @@ void tst_QXmppMessage::testEncryptedFileSource()
     }
 }
 
+void tst_QXmppMessage::testStickers()
+{
+    QByteArray xml(
+        "<message id='sharing-a-file' to='juliet@shakespeare.lit' from='romeo@montague.lit/pda' type='normal'>"
+        "<body>😘</body>"
+        "<file-sharing xmlns='urn:xmpp:sfs:0' disposition='inline'>"
+        "<file xmlns='urn:xmpp:file:metadata:0'>"
+        "<desc>😘</desc>"
+        "<hash xmlns='urn:xmpp:hashes:2' algo='sha-256'>gw+6xdCgOcvCYSKuQNrXH33lV9NMzuDf/s0huByCDsY=</hash>"
+        "<media-type>image/png</media-type>"
+        "<size>67016</size>"
+        "</file>"
+        "<sources>"
+        "<url-data xmlns='http://jabber.org/protocol/url-data' target='https://download.montague.lit/51078299-d071-46e1-b6d3-3de4a8ab67d6/sticker_marsey_kiss.png'/>"
+        "</sources>"
+        "</file-sharing>"
+        "<sticker xmlns='urn:xmpp:stickers:0' pack='EpRv28DHHzFrE4zd+xaNpVb4'/>"
+        "</message>");
+
+    QXmppMessage message1;
+    parsePacket(message1, xml);
+    QVERIFY(!message1.sharedFiles().empty());
+    QVERIFY(message1.stickerPackId().has_value());
+    serializePacket(message1, xml);
+}
+
 QTEST_MAIN(tst_QXmppMessage)
 #include "tst_qxmppmessage.moc"

Original file line number	Diff line number	Diff line change
`@@ -1843,6 +1843,7 @@ void QXmppMessage::serializeExtensions(QXmlStreamWriter *writer, QXmpp::SceMode`
`1843`	`1843`	`writer->writeStartElement("sticker");`
`1844`	`1844`	`writer->writeDefaultNamespace(ns_stickers);`
`1845`	`1845`	`writer->writeAttribute("pack", *d->stickerPackId);`
	`1846`	`+ writer->writeEndElement();`
`1846`	`1847`	`}`
`1847`	`1848`	`}`
`1848`	`1849`	`}`