From ebb66ffb22611d7cc1a50711b0c3eb5a609a5a79 Mon Sep 17 00:00:00 2001 From: wychen Date: Wed, 5 Apr 2017 00:19:37 -0700 Subject: [PATCH] Add missing header files to GN files (3 of N) I ran check_gn_headers.py on Mac and iOS full builds, merged the missing header file list, fed to fix_gn_headers.py (without AddHeadersToSources), and manually fixed the results. Read more about the manual fixes in the Review-Url. The number of missing header files on Mac and iOS decreased by 54, from 814 to 760. None of the fixed files are included in the following spreadsheet: https://docs.google.com/spreadsheets/d/15az3FMl-jAS0mx4E9XVSBVHVpmEzo-9EAGY0ywe7bZs/edit#gid=0 fix_gn_headers.py is from https://codereview.chromium.org/2790563003 BUG=661774 Review-Url: https://codereview.chromium.org/2788093002 Cr-Commit-Position: refs/heads/master@{#461999} --- components/os_crypt/BUILD.gn | 1 + content/test/fuzzer/BUILD.gn | 1 + ios/chrome/browser/tabs/BUILD.gn | 1 + .../src/libraries/nacl_io/BUILD.gn | 48 +++++++++++++++++++ net/BUILD.gn | 4 ++ remoting/base/BUILD.gn | 1 + .../boringssl/BUILD.generated_tests.gni | 1 + third_party/flatbuffers/BUILD.gn | 1 + 8 files changed, 58 insertions(+) diff --git a/components/os_crypt/BUILD.gn b/components/os_crypt/BUILD.gn index 19aa93eeafdcee..e91c6815e6a68a 100644 --- a/components/os_crypt/BUILD.gn +++ b/components/os_crypt/BUILD.gn @@ -58,6 +58,7 @@ static_library("os_crypt") { if (is_ios) { set_sources_assignment_filter([]) sources += [ + "keychain_password_mac.h", "keychain_password_mac.mm", "os_crypt_mac.mm", ] diff --git a/content/test/fuzzer/BUILD.gn b/content/test/fuzzer/BUILD.gn index e4459eda4d4b66..37db2da3790ba5 100644 --- a/content/test/fuzzer/BUILD.gn +++ b/content/test/fuzzer/BUILD.gn @@ -16,6 +16,7 @@ if (!is_component_build) { source_set("fuzzer_support") { sources = [ "fuzzer_support.cc", + "fuzzer_support.h", ] public_deps = [ "//base", diff --git a/ios/chrome/browser/tabs/BUILD.gn b/ios/chrome/browser/tabs/BUILD.gn index f5e8870dabc484..29ef489ad1fa24 100644 --- a/ios/chrome/browser/tabs/BUILD.gn +++ b/ios/chrome/browser/tabs/BUILD.gn @@ -31,6 +31,7 @@ source_set("tabs") { source_set("tabs_internal") { sources = [ + "tab.h", "tab.mm", "tab_model.mm", "tab_model_synced_window_delegate.mm", diff --git a/native_client_sdk/src/libraries/nacl_io/BUILD.gn b/native_client_sdk/src/libraries/nacl_io/BUILD.gn index 11ae14d7182c63..a4a1ed40aa39a7 100644 --- a/native_client_sdk/src/libraries/nacl_io/BUILD.gn +++ b/native_client_sdk/src/libraries/nacl_io/BUILD.gn @@ -20,33 +20,58 @@ config("nacl_io_include_dirs") { source_set("nacl_io") { sources = [ "devfs/dev_fs.cc", + "devfs/dev_fs.h", "devfs/jspipe_event_emitter.cc", + "devfs/jspipe_event_emitter.h", "devfs/jspipe_node.cc", + "devfs/jspipe_node.h", "devfs/tty_node.cc", + "devfs/tty_node.h", "dir_node.cc", + "dir_node.h", "event_emitter.cc", + "event_emitter.h", "event_listener.cc", + "event_listener.h", "fifo_char.cc", + "fifo_char.h", "filesystem.cc", + "filesystem.h", "fusefs/fuse_fs.cc", + "fusefs/fuse_fs.h", "fusefs/fuse_fs_factory.cc", + "fusefs/fuse_fs_factory.h", "getdents_helper.cc", + "getdents_helper.h", "googledrivefs/googledrivefs.cc", + "googledrivefs/googledrivefs.h", "googledrivefs/googledrivefs_node.cc", + "googledrivefs/googledrivefs_node.h", "h_errno.c", "hash.cc", "host_resolver.cc", + "host_resolver.h", "html5fs/html5_fs.cc", + "html5fs/html5_fs.h", "html5fs/html5_fs_node.cc", + "html5fs/html5_fs_node.h", "httpfs/http_fs.cc", + "httpfs/http_fs.h", "httpfs/http_fs_node.cc", + "httpfs/http_fs_node.h", "in6_addr.c", "jsfs/js_fs.cc", + "jsfs/js_fs.h", "jsfs/js_fs_node.cc", + "jsfs/js_fs_node.h", "kernel_handle.cc", + "kernel_handle.h", "kernel_intercept.cc", + "kernel_intercept.h", "kernel_object.cc", + "kernel_object.h", "kernel_proxy.cc", + "kernel_proxy.h", "kernel_wrap_dummy.cc", "kernel_wrap_glibc.cc", "kernel_wrap_irt_ext.c", @@ -54,29 +79,52 @@ source_set("nacl_io") { "kernel_wrap_win.cc", "log.c", "memfs/mem_fs.cc", + "memfs/mem_fs.h", "memfs/mem_fs_node.cc", + "memfs/mem_fs_node.h", "nacl_io.cc", + "nacl_io.h", "node.cc", + "node.h", "passthroughfs/passthrough_fs.cc", + "passthroughfs/passthrough_fs.h", "passthroughfs/real_node.cc", + "passthroughfs/real_node.h", "path.cc", "pepper_interface.cc", + "pepper_interface.h", "pepper_interface_delegate.cc", + "pepper_interface_delegate.h", "pipe/pipe_event_emitter.cc", + "pipe/pipe_event_emitter.h", "pipe/pipe_node.cc", + "pipe/pipe_node.h", "real_pepper_interface.cc", + "real_pepper_interface.h", "socket/fifo_packet.cc", + "socket/fifo_packet.h", "socket/packet.cc", + "socket/packet.h", "socket/socket_node.cc", + "socket/socket_node.h", "socket/tcp_event_emitter.cc", + "socket/tcp_event_emitter.h", "socket/tcp_node.cc", + "socket/tcp_node.h", "socket/udp_event_emitter.cc", + "socket/udp_event_emitter.h", "socket/udp_node.cc", + "socket/udp_node.h", "socket/unix_event_emitter.cc", + "socket/unix_event_emitter.h", "socket/unix_node.cc", + "socket/unix_node.h", "stream/stream_event_emitter.cc", + "stream/stream_event_emitter.h", "stream/stream_fs.cc", + "stream/stream_fs.h", "stream/stream_node.cc", + "stream/stream_node.h", "syscalls/access.c", "syscalls/chown.c", "syscalls/fchown.c", diff --git a/net/BUILD.gn b/net/BUILD.gn index ec63747b01dee8..0b8a35b4a45154 100644 --- a/net/BUILD.gn +++ b/net/BUILD.gn @@ -460,6 +460,7 @@ component("net") { "base/network_interfaces_linux.cc", "base/network_interfaces_linux.h", "base/network_interfaces_mac.cc", + "base/network_interfaces_mac.h", "base/network_interfaces_win.cc", "base/network_interfaces_win.h", "base/network_throttle_manager.h", @@ -1832,12 +1833,15 @@ component("net") { "base/mac/url_conversions.h", "base/mac/url_conversions.mm", "base/network_change_notifier_mac.cc", + "base/network_change_notifier_mac.h", "base/network_config_watcher_mac.cc", + "base/network_config_watcher_mac.h", "base/network_interfaces_mac.cc", "base/network_interfaces_mac.h", "base/platform_mime_util_mac.mm", "cert/test_root_certs_mac.cc", "proxy/proxy_resolver_mac.cc", + "proxy/proxy_resolver_mac.h", "proxy/proxy_server_mac.cc", ] diff --git a/remoting/base/BUILD.gn b/remoting/base/BUILD.gn index 539fa8702b18ab..e760a159d22e9e 100644 --- a/remoting/base/BUILD.gn +++ b/remoting/base/BUILD.gn @@ -107,6 +107,7 @@ source_set("breakpad") { sources = [ "breakpad.h", "breakpad_linux.cc", + "breakpad_linux.h", "breakpad_mac.mm", "breakpad_win.cc", ] diff --git a/third_party/boringssl/BUILD.generated_tests.gni b/third_party/boringssl/BUILD.generated_tests.gni index 2cdd2415e2723f..e83b7381a86c9b 100644 --- a/third_party/boringssl/BUILD.generated_tests.gni +++ b/third_party/boringssl/BUILD.generated_tests.gni @@ -8,6 +8,7 @@ test_support_sources = [ "src/crypto/test/file_test.cc", "src/crypto/test/file_test.h", "src/crypto/test/malloc.cc", + "src/crypto/test/malloc.h", "src/crypto/test/test_util.cc", "src/crypto/test/test_util.h", "src/ssl/test/async_bio.h", diff --git a/third_party/flatbuffers/BUILD.gn b/third_party/flatbuffers/BUILD.gn index a6dc8f42ec8533..5a3c3de5356d96 100644 --- a/third_party/flatbuffers/BUILD.gn +++ b/third_party/flatbuffers/BUILD.gn @@ -78,6 +78,7 @@ test("flatbuffers_unittest") { # This is the actual test. "src/tests/test.cpp", + "src/tests/test.h", ] deps = [ ":compiler_files",