From e72b2988f9a476220160347eb0c562fbb6697492 Mon Sep 17 00:00:00 2001 From: Omer Katz Date: Tue, 2 May 2023 14:43:49 +0000 Subject: [PATCH] [v8] Add feature flag for MinorMC Bug: v8:12612 Change-Id: I017e22445f5429663daa692cc5bdee4e866f528e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4498627 Reviewed-by: Michael Lippautz Commit-Queue: Omer Katz Cr-Commit-Position: refs/heads/main@{#1138346} --- gin/gin_features.cc | 3 +++ gin/gin_features.h | 1 + gin/v8_initializer.cc | 1 + 3 files changed, 5 insertions(+) diff --git a/gin/gin_features.cc b/gin/gin_features.cc index 12cc435c4c455e..bb59c447ae3282 100644 --- a/gin/gin_features.cc +++ b/gin/gin_features.cc @@ -87,6 +87,9 @@ BASE_FEATURE(kV8Turbofan, "V8Turbofan", base::FEATURE_ENABLED_BY_DEFAULT); // Enables experimental Maglev compiler. BASE_FEATURE(kV8Maglev, "V8Maglev", base::FEATURE_DISABLED_BY_DEFAULT); +// Enables MinorMC young generation garbage collector. +BASE_FEATURE(kV8MinorMC, "V8MinorMC", base::FEATURE_DISABLED_BY_DEFAULT); + // Enables Sparkplug compiler. Note that this only sets the V8 flag when // manually overridden; otherwise it defers to whatever the V8 default is. BASE_FEATURE(kV8Sparkplug, "V8Sparkplug", base::FEATURE_ENABLED_BY_DEFAULT); diff --git a/gin/gin_features.h b/gin/gin_features.h index 5181f0a550d704..c808e2b5a52dfd 100644 --- a/gin/gin_features.h +++ b/gin/gin_features.h @@ -28,6 +28,7 @@ GIN_EXPORT BASE_DECLARE_FEATURE(kV8FlushBytecode); GIN_EXPORT BASE_DECLARE_FEATURE(kV8FlushEmbeddedBlobICache); GIN_EXPORT BASE_DECLARE_FEATURE(kV8LazyFeedbackAllocation); GIN_EXPORT BASE_DECLARE_FEATURE(kV8Maglev); +GIN_EXPORT BASE_DECLARE_FEATURE(kV8MinorMC); GIN_EXPORT BASE_DECLARE_FEATURE(kV8MegaDomIC); GIN_EXPORT BASE_DECLARE_FEATURE(kV8MemoryReducerSingleGC); GIN_EXPORT BASE_DECLARE_FEATURE(kV8NoReclaimUnmodifiedWrappers); diff --git a/gin/v8_initializer.cc b/gin/v8_initializer.cc index 951279bd178e39..647e9bce52c57e 100644 --- a/gin/v8_initializer.cc +++ b/gin/v8_initializer.cc @@ -285,6 +285,7 @@ void SetFlags(IsolateHolder::ScriptMode mode, SetV8FlagsIfOverridden(features::kV8MegaDomIC, "--mega-dom-ic", "--no-mega-dom-ic"); SetV8FlagsIfOverridden(features::kV8Maglev, "--maglev", "--no-maglev"); + SetV8FlagsIfOverridden(features::kV8MinorMC, "--minor-mc", "--no-minor-mc"); SetV8FlagsIfOverridden(features::kV8Sparkplug, "--sparkplug", "--no-sparkplug"); SetV8FlagsIfOverridden(features::kV8Turbofan, "--turbofan", "--no-turbofan");