From c9b70a04aff5d1c976fd79afa6734f56eae0490a Mon Sep 17 00:00:00 2001 From: Etienne Pierre-doray Date: Thu, 16 Mar 2023 20:26:16 +0000 Subject: [PATCH] [battery] Deprecate BatterySamplingDelay Bug: 1421844 Change-Id: I0cb28da275c587e54bd84acef72989c6392adde6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4343935 Reviewed-by: Olivier Li Reviewed-by: Francois Pierre Doray Commit-Queue: Etienne Pierre-Doray Cr-Commit-Position: refs/heads/main@{#1118305} --- .../browser/metrics/power/power_metrics_reporter.cc | 12 +----------- .../browser/metrics/power/power_metrics_reporter.h | 1 - .../metrics/histograms/metadata/power/histograms.xml | 11 ----------- 3 files changed, 1 insertion(+), 23 deletions(-) diff --git a/chrome/browser/metrics/power/power_metrics_reporter.cc b/chrome/browser/metrics/power/power_metrics_reporter.cc index ec90920d079fed..d8bbf2aa49993a 100644 --- a/chrome/browser/metrics/power/power_metrics_reporter.cc +++ b/chrome/browser/metrics/power/power_metrics_reporter.cc @@ -29,9 +29,6 @@ namespace { -constexpr const char* kBatterySamplingDelayHistogramName = - "Power.BatterySamplingDelay"; - // Calculates the UKM bucket |value| falls in and returns it. This uses an // exponential bucketing approach with an exponent base of 1.3, resulting in // 17 buckets for an interval of 120 seconds. @@ -203,8 +200,7 @@ void PowerMetricsReporter::OnAggregatedMetricsSampled( // |battery_level_provider_|. battery_level_provider_->GetBatteryState(base::BindOnce( &PowerMetricsReporter::OnBatteryAndAggregatedProcessMetricsSampled, - base::Unretained(this), metrics, interval_duration, - /*battery_sample_begin_time=*/now)); + base::Unretained(this), metrics, interval_duration)); } else { // Get usage scenario data. auto long_interval_data = @@ -216,17 +212,11 @@ void PowerMetricsReporter::OnAggregatedMetricsSampled( void PowerMetricsReporter::OnBatteryAndAggregatedProcessMetricsSampled( const ProcessMonitor::Metrics& aggregated_process_metrics, base::TimeDelta interval_duration, - base::TimeTicks battery_sample_begin_time, const absl::optional& new_battery_state) { DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_); DCHECK(battery_level_provider_); - // Report time it took to sample the battery state. - base::UmaHistogramMicrosecondsTimes( - kBatterySamplingDelayHistogramName, - base::TimeTicks::Now() - battery_sample_begin_time); - // Evaluate battery discharge mode and rate. auto previous_battery_state = std::exchange(battery_state_, new_battery_state); diff --git a/chrome/browser/metrics/power/power_metrics_reporter.h b/chrome/browser/metrics/power/power_metrics_reporter.h index 973e4bcf6cdcb3..0c6b3d7287674c 100644 --- a/chrome/browser/metrics/power/power_metrics_reporter.h +++ b/chrome/browser/metrics/power/power_metrics_reporter.h @@ -106,7 +106,6 @@ class PowerMetricsReporter : public ProcessMonitor::Observer { void OnBatteryAndAggregatedProcessMetricsSampled( const ProcessMonitor::Metrics& aggregated_process_metrics, base::TimeDelta interval_duration, - base::TimeTicks battery_sample_begin_time, const absl::optional& new_battery_state); diff --git a/tools/metrics/histograms/metadata/power/histograms.xml b/tools/metrics/histograms/metadata/power/histograms.xml index a45a35248bc45b..6a192e781339ea 100644 --- a/tools/metrics/histograms/metadata/power/histograms.xml +++ b/tools/metrics/histograms/metadata/power/histograms.xml @@ -1145,17 +1145,6 @@ chromium-metrics-reviews@google.com. - - etiennep@chromium.org - fdoray@chromium.org - - The delay in microseconds between the time a battery charge level query was - schedule and the time the state is made available, reported everytime the - battery charge level is sampled. Reported for all users on Windows and Mac. - - - dianders@chromium.org