From bda90b71cdbfa7f02f26960634ad339590f3944f Mon Sep 17 00:00:00 2001 From: Nick Diego Yamane Date: Mon, 1 Jul 2019 17:19:01 +0000 Subject: [PATCH] docs: Remove Gtk/ViewsGtk docs ViewsGtk has been removed from the code base so this CL removes this docs leftover. Bug: None Change-Id: I82c5d29c07bfada954ca94cfffe26609fde9db16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1683613 Reviewed-by: Scott Violet Commit-Queue: Nick Yamane Cr-Commit-Position: refs/heads/master@{#673743} --- docs/README.md | 2 -- docs/gtk_vs_views_gtk.md | 38 -------------------------------------- 2 files changed, 40 deletions(-) delete mode 100644 docs/gtk_vs_views_gtk.md diff --git a/docs/README.md b/docs/README.md index 79a75af86ff786..ed8f04fd12e708 100644 --- a/docs/README.md +++ b/docs/README.md @@ -193,8 +193,6 @@ used when committed. * [Tips for Debugging on Linux](linux_debugging.md) * [Linux GTK Theme Integration](linux_gtk_theme_integration.md) - Having Chrome match the GTK+ theme. -* [Gtk vs ViewsGtk](gtk_vs_views_gtk.md) - Notes on when to use Gtk vs - ViewsGtk * [Browser Plugins on Linux](linux_plugins.md) - A collection of links to information on how browser plugins work on Linux * [Linux Crash Dumping](linux_crash_dumping.md) - How Breakpad uploads crash diff --git a/docs/gtk_vs_views_gtk.md b/docs/gtk_vs_views_gtk.md deleted file mode 100644 index faf93085f36907..00000000000000 --- a/docs/gtk_vs_views_gtk.md +++ /dev/null @@ -1,38 +0,0 @@ -# Gtk vs ViewsGtk - -## Benefits of ViewsGtk - -* Better code sharing. For example, don't have to duplicate tab layout or - bookmark bar layout code. - * Tab Strip - * Drawing - * All the animationy bits - * Subtle click selection behavior (curved corners) - * Drag behavior, including dropping of files onto the URL bar - * Closing behavior - * Bookmarks bar - * drag & drop behavior, including menus - * chevron? -* Easier for folks to work on both platforms without knowing much about the - underlying toolkits. -* Don't have to implement ui features twice. - -## Benefits of Gtk - -* Dialogs - * Native feel layout - * Font size changes (e.g., changing the system font size will apply to our - dialogs) - * Better RTL (e.g., https://crbug.com/2822 https://crbug.com/5729 - https://crbug.com/6082 https://crbug.com/6103 https://crbug.com/6125 - https://crbug.com/8686 https://crbug.com/8649) -* Being able to obey the user's system theme -* Accessibility for buttons and dialogs (but not for tabstrip and bookmarks) -* A better change at good remote X performance? -* We still would currently need Pango / Cairo for text layout, so it will be - more efficient to just draw that during the Gtk pipeline instead of with - Skia. -* Gtk widgets will automatically "feel and behave" like Linux. The behavior of - our own Views system does not necessarily feel right on Linux. -* People working on Windows features don't need to worry about breaking the - Linux build.